From 19f33a2a0274906fd35512cc36fd7b1bb17b13d0 Mon Sep 17 00:00:00 2001 From: Shaun Date: Thu, 28 Apr 2022 06:38:41 +0200 Subject: [PATCH] bug #1932: Got rid of memory leak --- src/server/clientComponents/inventory.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/server/clientComponents/inventory.js b/src/server/clientComponents/inventory.js index 1f6aa504..f4fa78d6 100644 --- a/src/server/clientComponents/inventory.js +++ b/src/server/clientComponents/inventory.js @@ -28,9 +28,11 @@ define([ if (!findItem) { rerenderNeeded = true; - g.isNew = true; - items.push(g); + const clonedItem = $.extend({}, g); + clonedItem.isNew = true; + + items.push(clonedItem); return; } @@ -49,7 +51,7 @@ define([ delete findItem[p]; }); - Object.assign(findItem, g); + $.extend(findItem, g); }); events.emit('onGetItems', this.items, rerenderNeeded, getItems);