From 38da1359f1acd659bfd6bae99c1df612ef1c6d0f Mon Sep 17 00:00:00 2001 From: Big Bad Waffle Date: Fri, 10 Nov 2017 19:54:52 +0200 Subject: [PATCH 1/2] fixed #347 --- src/server/components/effects.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/server/components/effects.js b/src/server/components/effects.js index 0fa4b3f0..ea847490 100644 --- a/src/server/components/effects.js +++ b/src/server/components/effects.js @@ -213,9 +213,11 @@ define([ var eLen = effects.length; for (var i = 0; i < eLen; i++) { var e = effects[i]; + + //Maybe the effect killed us? if (!e) { - console.log('NO EFFECT'); - console.log(this.obj.name, event); + eLen--; + continue; } if (e.ttl <= 0) From 6a8b61f97b11e2d5c770dc2477d8d5400c44e376 Mon Sep 17 00:00:00 2001 From: Big Bad Waffle Date: Fri, 10 Nov 2017 22:38:53 +0200 Subject: [PATCH 2/2] forgot to decrease counter --- src/server/components/effects.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/components/effects.js b/src/server/components/effects.js index ea847490..92f39c8e 100644 --- a/src/server/components/effects.js +++ b/src/server/components/effects.js @@ -216,6 +216,7 @@ define([ //Maybe the effect killed us? if (!e) { + i--; eLen--; continue; }