Merge branch '1877-faction-item-vendor-fix' into 'master'

bug #1877: Move the canBuy check from factionVendor.js to trade.js

Closes #1877

See merge request Isleward/isleward!578

src/server/components/extensions/factionVendor.js

@@ -149,25 +149,6 @@ module.exports = {
 		}
 	},
 
-	canBuy: function (itemId, requestedBy, action) {
-		let item = null;
-		if (action === 'buy')
-			item = this.findItem(itemId, requestedBy.name);
-		else if (action === 'buyback')
-			item = this.findBuyback(itemId, requestedBy.name);
-
-		let result = true;
-		if (item.factions)
-			result = requestedBy.reputation.canEquipItem(item);
-
-		if (!result) {
-			const message = 'your reputation is too low to buy that item';
-			requestedBy.social.notifySelf({ message });
-		}
-
-		return result;
-	},
-
 	findItem: function (itemId, sourceName) {
 		let list = this.items[sourceName];
 		if (!list)

src/server/components/trade.js

@@ -341,7 +341,22 @@ module.exports = {
 	},
 
 	canBuy: function (itemId, requestedBy, action) {
-		return true;
+		let item = null;
+		if (action === 'buy')
+			item = this.findItem(itemId, requestedBy.name);
+		else if (action === 'buyback')
+			item = this.findBuyback(itemId, requestedBy.name);
+
+		let result = true;
+		if (item.factions)
+			result = requestedBy.reputation.canEquipItem(item);
+
+		if (!result) {
+			const message = 'your reputation is too low to buy that item';
+			requestedBy.social.notifySelf({ message });
+		}
+
+		return result;
 	},
 
 	findItem: function (itemId, sourceName) {