Browse Source

Allow newsfragments to end with exclamation marks! (#4912)

tags/v0.99.3rc1
Richard van der Hoff 5 years ago
committed by GitHub
parent
commit
224783a73f
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
  1. +1
    -0
      changelog.d/4912.misc
  2. +2
    -2
      scripts-dev/check-newsfragment

+ 1
- 0
changelog.d/4912.misc View File

@@ -0,0 +1 @@
Allow newsfragments to end with exclamation marks. Exciting!

+ 2
- 2
scripts-dev/check-newsfragment View File

@@ -31,8 +31,8 @@ echo
# check that any new newsfiles on this branch end with a full stop.
for f in `git diff --name-only FETCH_HEAD... -- changelog.d`; do
lastchar=`tr -d '\n' < $f | tail -c 1`
if [ $lastchar != '.' ]; then
echo -e "\e[31mERROR: newsfragment $f does not end with a '.'\e[39m" >&2
if [ $lastchar != '.' -a $lastchar != '!' ]; then
echo -e "\e[31mERROR: newsfragment $f does not end with a '.' or '!'\e[39m" >&2
exit 1
fi
done


Loading…
Cancel
Save