Browse Source

Allow modules to run looping call on all instances (#10638)

By default the calls only ran on the worker configured to run background
tasks.
tags/v1.41.0rc1
Erik Johnston 2 years ago
committed by GitHub
parent
commit
5581dd7bf7
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
  1. +1
    -0
      changelog.d/10638.feature
  2. +8
    -1
      synapse/module_api/__init__.py

+ 1
- 0
changelog.d/10638.feature View File

@@ -0,0 +1 @@
Add option to allow modules to run periodic tasks on all instances, rather than just the one configured to run background tasks.

+ 8
- 1
synapse/module_api/__init__.py View File

@@ -604,10 +604,15 @@ class ModuleApi:
msec: float,
*args,
desc: Optional[str] = None,
run_on_all_instances: bool = False,
**kwargs,
):
"""Wraps a function as a background process and calls it repeatedly.

NOTE: Will only run on the instance that is configured to run
background processes (which is the main process by default), unless
`run_on_all_workers` is set.

Waits `msec` initially before calling `f` for the first time.

Args:
@@ -618,12 +623,14 @@ class ModuleApi:
msec: How long to wait between calls in milliseconds.
*args: Positional arguments to pass to function.
desc: The background task's description. Default to the function's name.
run_on_all_instances: Whether to run this on all instances, rather
than just the instance configured to run background tasks.
**kwargs: Key arguments to pass to function.
"""
if desc is None:
desc = f.__name__

if self._hs.config.run_background_tasks:
if self._hs.config.run_background_tasks or run_on_all_instances:
self._clock.looping_call(
run_as_background_process,
msec,


Loading…
Cancel
Save