synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	aa483cb4c9	Update ruff config (#16283 ) Enable additional checks & clean-up unneeded configuration.	8 months ago
Patrick Cloke	9ec3da06da	Bump mypy-zope & mypy. (#16188 )	8 months ago
Eric Eastwood	8bfded81f3	Trace functions which return `Awaitable` (#15650 )	11 months ago
David Robertson	ffc2ee521d	Use mypy 1.0 (#15052 ) * Update mypy and mypy-zope * Remove unused ignores These used to suppress ``` synapse/storage/engines/__init__.py:28: error: "__new__" must return a class instance (got "NoReturn") [misc] ``` and ``` synapse/http/matrixfederationclient.py:1270: error: "BaseException" has no attribute "reasons" [attr-defined] ``` (note that we check `hasattr(e, "reasons")` above) * Avoid empty body warnings, sometimes by marking methods as abstract E.g. ``` tests/handlers/test_register.py:58: error: Missing return statement [empty-body] tests/handlers/test_register.py:108: error: Missing return statement [empty-body] ``` * Suppress false positive about `JaegerConfig` Complaint was ``` synapse/logging/opentracing.py:450: error: Function "Type[Config]" could always be true in boolean context [truthy-function] ``` * Fix not calling `is_state()` Oops! ``` tests/rest/client/test_third_party_rules.py:428: error: Function "Callable[[], bool]" could always be true in boolean context [truthy-function] ``` * Suppress false positives from ParamSpecs ```` synapse/logging/opentracing.py:971: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], P], _GeneratorContextManager[None]]" [arg-type] synapse/logging/opentracing.py:1017: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], P], _GeneratorContextManager[None]]" [arg-type] ```` * Drive-by improvement to `wrapping_logic` annotation * Workaround false "unreachable" positives See https://github.com/Shoobx/mypy-zope/issues/91 ``` tests/http/test_proxyagent.py:626: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:762: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:826: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:838: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:845: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:151: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:452: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:60: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:93: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:127: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:152: error: Statement is unreachable [unreachable] ``` * Changelog * Tweak DBAPI2 Protocol to be accepted by mypy 1.0 Some extra context in: - https://github.com/matrix-org/python-canonicaljson/pull/57 - https://github.com/python/mypy/issues/6002 - https://mypy.readthedocs.io/en/latest/common_issues.html#covariant-subtyping-of-mutable-protocol-members-is-rejected * Pull in updated canonicaljson lib so the protocol check just works * Improve comments in opentracing I tried to workaround the ignores but found it too much trouble. I think the corresponding issue is https://github.com/python/mypy/issues/12909. The mypy repo has a PR claiming to fix this (https://github.com/python/mypy/pull/14677) which might mean this gets resolved soon? * Better annotation for INTERACTIVE_AUTH_CHECKERS * Drive-by AUTH_TYPE annotation, to remove an ignore	1 year ago
Patrick Cloke	fc35e0673f	Add missing type hints in tests (#14879 ) * FIx-up type hints in tests.logging. * Add missing type hints to test_transactions.	1 year ago
Hugh Nimmo-Smith	4eaf3eb840	Implementation of HTTP 307 response for MSC3886 POST endpoint (#14018 ) Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: Andrew Morgan <andrewm@element.io>	1 year ago
Eric Eastwood	1b09b0832e	Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453 ) ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```	1 year ago
Patrick Cloke	50122754c8	Add missing types to opentracing. (#13345 ) After this change `synapse.logging` is fully typed.	1 year ago
Patrick Cloke	6ad012ef89	More type hints for `synapse.logging` (#13103 ) Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.	1 year ago
Richard van der Hoff	31b554c297	Fixes for opentracing scopes (#11869 ) `start_active_span` was inconsistent as to whether it would activate the span immediately, or wait for `scope.__enter__` to happen (it depended on whether the current logcontext already had an associated scope). The inconsistency was rather confusing if you were hoping to set up a couple of separate spans before activating either. Looking at the other implementations of opentracing `ScopeManager`s, the intention is that it should be activated immediately, as the name implies. Indeed, the idea is that you don't have to use the scope as a contextmanager at all - you can just call `.close` on the result. Hence, our cleanup has to happen in `.close` rather than `.__exit__`. So, the main change here is to ensure that `start_active_span` does activate the span, and that `scope.close()` does close the scope. We also add some tests, which requires a `tracer` param so that we don't have to rely on the global variable in unit tests.	2 years ago
Nick Barrett	bb228f3523	Include exception in json logging (#11028 )	2 years ago
Erik Johnston	50022cff96	Add reactor to `SynapseRequest` and fix up types. (#10868 )	2 years ago
Patrick Cloke	b076bc276e	Always use the name as the log ID. (#9829 ) As far as I can tell our logging contexts are meant to log the request ID, or sometimes the request ID followed by a suffix (this is generally stored in the name field of LoggingContext). There's also code to log the name@memory location, but I'm not sure this is ever used. This simplifies the code paths to require every logging context to have a name and use that in logging. For sub-contexts (created via nested_logging_contexts, defer_to_threadpool, Measure) we use the current context's str (which becomes their name or the string "sentinel") and then potentially modify that (e.g. add a suffix).	3 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	3 years ago
Patrick Cloke	0b3112123d	Use mock from the stdlib. (#9772 )	3 years ago
Patrick Cloke	48d44ab142	Record more information into structured logs. (#9654 ) Records additional request information into the structured logs, e.g. the requester, IP address, etc.	3 years ago
Patrick Cloke	1619802228	Various clean-ups to the logging context code (#8935 )	3 years ago
Patrick Cloke	3af0672350	Improve tests for structured logging. (#8916 )	3 years ago
Patrick Cloke	8b42a4eefd	Gracefully handle a pending logging connection during shutdown. (#8685 )	3 years ago
Patrick Cloke	00b24aa545	Support generating structured logs in addition to standard logs. (#8607 ) This modifies the configuration of structured logging to be usable from the standard Python logging configuration. This also separates the formatting of logs from the transport allowing JSON logs to files or standard logs to sockets.	3 years ago
Patrick Cloke	20a67aa70d	Separate the TCP and terse JSON formatting code. (#8587 ) This should (theoretically) allow for using the TCP code with a different output type and make it easier to use the JSON code with files / console.	3 years ago
Patrick Cloke	c619253db8	Stop sub-classing object (#8249 )	3 years ago
Amber Brown	b617864cd9	Fix for structured logging tests stomping on logs (#6023 )	4 years ago
Amber Brown	7dc398586c	Implement a structured logging output system. (#5680 )	4 years ago

25 Commits (develop)