synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	4eed7b2ede	Add missing type hints to tests. (#15027 )	1 year ago
David Robertson	510d4b06e7	Handle malformed values of `notification.room` in power level events (#14942 ) * Better test for bad values in power levels events The previous test only checked that Synapse didn't raise an exception, but didn't check that we had correctly interpreted the value of the dodgy power level. It also conflated two things: bad room notification levels, and bad user levels. There _is_ logic for converting the latter to integers, but we should test it separately. * Check we ignore types that don't convert to int * Handle `None` values in `notifications.room` * Changelog * Also test that bad values are rejected by event auth * Docstring * linter scripttttttttt	1 year ago
reivilibre	c2fe48a6ff	Rename the `EventFormatVersions` enum values so that they line up with room version numbers. (#13706 )	1 year ago
Shay	ad5761b65c	Add support for room version 10 (#13220 )	1 year ago
Richard van der Hoff	d4b1c0d800	Fix inconsistencies in event validation (#13088 )	1 year ago
Richard van der Hoff	e16ea87d0f	Fix inconsistencies in event validation for `m.room.create` events (#13087 ) * Extend the auth rule checks for `m.room.create` events ... and move them up to the top of the function. Since the no auth_events are allowed for m.room.create events, we may as well get the m.room.create event checks out of the way first. * Add a test for create events with prev_events	1 year ago
Richard van der Hoff	8ecf6be1e1	Move some event auth checks out to a different method (#13065 ) * Add auth events to events used in tests * Move some event auth checks out to a different method Some of the event auth checks apply to an event's auth_events, rather than the state at the event - which means they can play no part in state resolution. Move them out to a separate method. * Rename check_auth_rules_for_event Now it only checks the state-dependent auth rules, it needs a better name.	1 year ago
Richard van der Hoff	0d9d36b15c	Remove `room_version` param from `check_auth_rules_for_event` Instead, use the `room_version` property of the event we're checking. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.	1 year ago
Richard van der Hoff	2959184a42	EventAuthTestCase: build events for the right room version In practice, when we run the auth rules, all of the events have the right room version. Let's stop building Room V1 events for these tests and use the right version.	1 year ago
Richard van der Hoff	a5d2ea3d08	Check all auth events for room id and rejection (#11009 ) This fixes a bug where we would accept an event whose `auth_events` include rejected events, if the rejected event was shadowed by another `auth_event` with same `(type, state_key)`. The approach is to pass a list of auth events into `check_auth_rules_for_event` instead of a dict, which of course means updating the call sites. This is an extension of #10956.	2 years ago
Patrick Cloke	32072dcdac	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	2 years ago
Patrick Cloke	d1bf5f7c9d	Strip "join_authorised_via_users_server" from join events which do not need it. (#10933 ) This fixes a "Event not signed by authorising server" error when transition room member from join -> join, e.g. when updating a display name or avatar URL for restricted rooms.	2 years ago
Richard van der Hoff	428174f902	Split `event_auth.check` into two parts (#10940 ) Broadly, the existing `event_auth.check` function has two parts: * a validation section: checks that the event isn't too big, that it has the rught signatures, etc. This bit is independent of the rest of the state in the room, and so need only be done once for each event. * an auth section: ensures that the event is allowed, given the rest of the state in the room. This gets done multiple times, against various sets of room state, because it forms part of the state res algorithm. Currently, this is implemented with `do_sig_check` and `do_size_check` parameters, but I think that makes everything hard to follow. Instead, we split the function in two and call each part separately where it is needed.	2 years ago
Patrick Cloke	0c246dd4a0	Support MSC3289: Room version 8 (#10449 ) This adds support for MSC3289: room version 8. This is room version 7 + MSC3083.	2 years ago
Patrick Cloke	228decfce1	Update the MSC3083 support to verify if joins are from an authorized server. (#10254 )	2 years ago
Patrick Cloke	eb3beb8f12	Add type hints and comments to event auth code. (#10393 )	2 years ago
Jonathan de Jong	4b965c862d	Remove redundant "coding: utf-8" lines (#9786 ) Part of #9744 Removes all redundant `# -- coding: utf-8 --` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`	3 years ago
Patrick Cloke	35c5ef2d24	Add an experimental room version to support restricted join rules. (#9717 ) Per MSC3083.	3 years ago
Eric Eastwood	0a00b7ff14	Update black, and run auto formatting over the codebase (#9381 ) - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](`80d6dc9783/docs/code_style.md)` - Update `code_style.md` docs around installing black to use the correct version	3 years ago
Patrick Cloke	08bc80ef09	Implement room version 6 (MSC2240). (#7506 )	4 years ago
Patrick Cloke	fef3ff5cc4	Enforce MSC2209: auth rules for notifications in power level event (#7502 ) In a new room version, the "notifications" key of power level events are subject to restricted auth rules.	4 years ago
Patrick Cloke	06eb5cae08	Remove special auth and redaction rules for aliases events in experimental room ver. (#7037 )	4 years ago
Richard van der Hoff	799001f2c0	Add a `make_event_from_dict` method (#6858 ) ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors.	4 years ago
Richard van der Hoff	a8ce7aeb43	Pass room version object into event_auth.check and check_redaction (#6788 ) These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.	4 years ago
Amber Brown	b36c82576e	Run Black on the tests again (#5170 )	5 years ago
Richard van der Hoff	54a87a7b08	Collect room-version variations into one place (#4969 ) Collect all the things that make room-versions different to one another into one place, so that it's easier to define new room versions.	5 years ago
Erik Johnston	ae2a957dba	Pass through room version to event auth	5 years ago
black	8b3d9b6b19	Run black.	5 years ago
Amber Brown	49af402019	run isort	5 years ago
Richard van der Hoff	a502cfec00	remove spurious debug	6 years ago
Richard van der Hoff	5c9afd6f80	Make default state_default 50 Make it so that, before there is a power-levels event in the room, you need a power level of at least 50 to send state. Partially addresses https://github.com/matrix-org/matrix-doc/issues/1192	6 years ago

30 Commits (develop)