synapse

Commit Graph

Author	SHA1	Message	Date
Patrick Cloke	691593bf71	Fix an edge-case with invited rooms over federation in the spaces summary. (#10560 ) If a room which the requesting user was invited to was queried over federation it will now properly appear in the spaces summary (instead of being stripped out by the requesting server).	2 years ago
Hillery Shay	52bfa2d59a	Update contributing.md to warn against rebasing an open PR. (#10563 ) Signed-off-by: H.Shay <shaysquared@gmail.com>	2 years ago
Brendan Abolivier	b5de77cf86	Merge branch 'master' into develop	2 years ago
Brendan Abolivier	9f7c038272	1.40.0	2 years ago
Eric Eastwood	7afb615839	When redacting, keep event fields around that maintain the historical event structure intact (MSC2716) (#10538 ) * Keep event fields that maintain the historical event structure intact Fix https://github.com/matrix-org/synapse/issues/10521 * Add changelog * Bump room version * Better changelog text * Fix up room version after develop merge	2 years ago
Dirk Klimpel	6b61debf5c	Do not remove `status_msg` when user going offline (#10550 ) Signed-off-by: Dirk Klimpel dirk@klimpel.org	2 years ago
Drew Short	189c055eb6	Moved homeserver documentation above reverse proxy examples (#10551 ) Signed-off-by: Drew Short <warrick@sothr.com>	2 years ago
Brendan Abolivier	f8e86b7d2e	Merge branch 'release-v1.40' into develop	2 years ago
Brendan Abolivier	ad35b7739e	1.40.0rc3	2 years ago
Patrick Cloke	0c246dd4a0	Support MSC3289: Room version 8 (#10449 ) This adds support for MSC3289: room version 8. This is room version 7 + MSC3083.	2 years ago
Patrick Cloke	1de26b3467	Convert Transaction and Edu object to attrs (#10542 ) Instead of wrapping the JSON into an object, this creates concrete instances for Transaction and Edu. This allows for improved type hints and simplified code.	2 years ago
Erik Johnston	60f0534b6e	Fix exceptions in logs when failing to get remote room list (#10541 )	2 years ago
Richard van der Hoff	1bebc0b78c	Clean up federation event auth code (#10539 ) * drop old-room hack pretty sure we don't need this any more. * Remove incorrect comment about modifying `context` It doesn't look like the supplied context is ever modified. * Stop `_auth_and_persist_event` modifying its parameters This is only called in three places. Two of them don't pass `auth_events`, and the third doesn't use the dict after passing it in, so this should be non-functional. * Stop `_check_event_auth` modifying its parameters `_check_event_auth` is only called in three places. `on_send_membership_event` doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not use the map after passing it in. * Stop `_update_auth_events_and_context_for_auth` modifying its parameters Return the updated auth event dict, rather than modifying the parameter. This is only called from `_check_event_auth`. * Improve documentation on `_auth_and_persist_event` Rename `auth_events` parameter to better reflect what it contains. * Improve documentation on `_NewEventInfo` * Improve documentation on `_check_event_auth` rename `auth_events` parameter to better describe what it contains * changelog	2 years ago
Patrick Cloke	f4ade972ad	Update the API response for spaces summary over federation. (#10530 ) This adds 'allowed_room_ids' (in addition to 'allowed_spaces', for backwards compatibility) to the federation response of the spaces summary. A future PR will remove the 'allowed_spaces' flag.	2 years ago
Richard van der Hoff	74d7336686	Add a setting to disable TLS for sending email (#10546 ) This is mostly useful in case the server offers TLS, but doesn't present a valid certificate.	2 years ago
Eric Eastwood	f5a368bb48	Mark all MSC2716 events as historical (#10537 ) * Mark all MSC2716 events as historical	2 years ago
Richard van der Hoff	0cb4274dbf	Merge remote-tracking branch 'origin/release-v1.40' into develop	2 years ago
Dirk Klimpel	4578531002	fix broken links in `upgrade.md` (#10543 ) Signed-off-by: Dirk Klimpel dirk@klimpel.org	2 years ago
Patrick Cloke	3b354faad0	Refactoring before implementing the updated spaces summary. (#10527 ) This should have no user-visible changes, but refactors some pieces of the SpaceSummaryHandler before adding support for the updated MSC2946.	2 years ago
Will Hunt	a8a27b2b8b	Only return an appservice protocol if it has a service providing it. (#10532 ) If there are no services providing a protocol, omit it completely instead of returning an empty dictionary. This fixes a long-standing spec compliance bug.	2 years ago
Dirk Klimpel	834cdc3606	Add documentation for configuring a forward proxy. (#10443 )	2 years ago
Erik Johnston	e33f14e8d5	Don't fail CI when lint-newfile job was skipped (#10529 )	2 years ago
Erik Johnston	a36d77c563	Merge tag 'v1.40.0rc2' into develop Synapse 1.40.0rc2 (2021-08-04) ============================== Bugfixes -------- - Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread. ([\#10517](https://github.com/matrix-org/synapse/issues/10517)) - Fix a bug introduced in Synapse v1.40.0rc1 that could cause Synapse to respond with an error when clients would update read receipts. ([\#10531](https://github.com/matrix-org/synapse/issues/10531)) Internal Changes ---------------- - Fix release script to open the correct URL for the release. ([\#10516](https://github.com/matrix-org/synapse/issues/10516))	2 years ago
Michael Telatynski	9db24cc50d	Send unstable-prefixed room_type in store-invite IS API requests (#10435 ) The room type is per MSC3288 to allow the identity-server to change invitation wording based on whether the invitation is to a room or a space. The prefixed key will be replaced once MSC3288 is accepted into the spec.	2 years ago
Eric Eastwood	684d19a11c	Add support for MSC2716 marker events (#10498 ) * Make historical messages available to federated servers Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716 Follow-up to https://github.com/matrix-org/synapse/pull/9247 * Debug message not available on federation * Add base starting insertion point when no chunk ID is provided * Fix messages from multiple senders in historical chunk Follow-up to https://github.com/matrix-org/synapse/pull/9247 Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716 --- Previously, Synapse would throw a 403, `Cannot force another user to join.`, because we were trying to use `?user_id` from a single virtual user which did not match with messages from other users in the chunk. * Remove debug lines * Messing with selecting insertion event extremeties * Move db schema change to new version * Add more better comments * Make a fake requester with just what we need See https://github.com/matrix-org/synapse/pull/10276#discussion_r660999080 * Store insertion events in table * Make base insertion event float off on its own See https://github.com/matrix-org/synapse/pull/10250#issuecomment-875711889 Conflicts: synapse/rest/client/v1/room.py * Validate that the app service can actually control the given user See https://github.com/matrix-org/synapse/pull/10276#issuecomment-876316455 Conflicts: synapse/rest/client/v1/room.py * Add some better comments on what we're trying to check for * Continue debugging * Share validation logic * Add inserted historical messages to /backfill response * Remove debug sql queries * Some marker event implemntation trials * Clean up PR * Rename insertion_event_id to just event_id * Add some better sql comments * More accurate description * Add changelog * Make it clear what MSC the change is part of * Add more detail on which insertion event came through * Address review and improve sql queries * Only use event_id as unique constraint * Fix test case where insertion event is already in the normal DAG * Remove debug changes * Add support for MSC2716 marker events * Process markers when we receive it over federation * WIP: make hs2 backfill historical messages after marker event * hs2 to better ask for insertion event extremity But running into the `sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group` error * Add insertion_event_extremities table * Switch to chunk events so we can auth via power_levels Previously, we were using `content.chunk_id` to connect one chunk to another. But these events can be from any `sender` and we can't tell who should be able to send historical events. We know we only want the application service to do it but these events have the sender of a real historical message, not the application service user ID as the sender. Other federated homeservers also have no indicator which senders are an application service on the originating homeserver. So we want to auth all of the MSC2716 events via power_levels and have them be sent by the application service with proper PL levels in the room. * Switch to chunk events for federation * Add unstable room version to support new historical PL * Messy: Fix undefined state_group for federated historical events ``` 2021-07-13 02:27:57,810 - synapse.handlers.federation - 1248 - ERROR - GET-4 - Failed to backfill from hs1 because NOT NULL constraint failed: event_to_state_groups.state_group Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1216, in try_backfill await self.backfill( File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 1035, in backfill await self._auth_and_persist_event(dest, event, context, backfilled=True) File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2222, in _auth_and_persist_event await self._run_push_actions_and_persist_event(event, context, backfilled) File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 2244, in _run_push_actions_and_persist_event await self.persist_events_and_notify( File "/usr/local/lib/python3.8/site-packages/synapse/handlers/federation.py", line 3290, in persist_events_and_notify events, max_stream_token = await self.storage.persistence.persist_events( File "/usr/local/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 774, in _trace_inner return await func(args, kwargs) File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 320, in persist_events ret_vals = await yieldable_gather_results(enqueue, partitioned.items()) File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 237, in handle_queue_loop ret = await self._per_item_callback( File "/usr/local/lib/python3.8/site-packages/synapse/storage/persist_events.py", line 577, in _persist_event_batch await self.persist_events_store._persist_events_and_state_updates( File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 176, in _persist_events_and_state_updates await self.db_pool.runInteraction( File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 681, in runInteraction result = await self.runWithConnection( File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 770, in runWithConnection return await make_deferred_yieldable( File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 238, in inContext result = inContext.theWork() # type: ignore[attr-defined] File "/usr/local/lib/python3.8/site-packages/twisted/python/threadpool.py", line 254, in <lambda> inContext.theWork = lambda: context.call( # type: ignore[attr-defined] File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, args, *kw) File "/usr/local/lib/python3.8/site-packages/twisted/python/context.py", line 83, in callWithContext return func(args, *kw) File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection compat.reraise(excValue, excTraceback) File "/usr/local/lib/python3.8/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction return function(args, *kwargs) File "/usr/local/lib/python3.8/site-packages/twisted/python/compat.py", line 403, in reraise raise exception.with_traceback(traceback) File "/usr/local/lib/python3.8/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection result = func(conn, args, *kw) File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 765, in inner_func return func(db_conn, args, *kwargs) File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 549, in new_transaction r = func(cursor, args, *kwargs) File "/usr/local/lib/python3.8/site-packages/synapse/logging/utils.py", line 69, in wrapped return f(args, *kwargs) File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 385, in _persist_events_txn self._store_event_state_mappings_txn(txn, events_and_contexts) File "/usr/local/lib/python3.8/site-packages/synapse/storage/databases/main/events.py", line 2065, in _store_event_state_mappings_txn self.db_pool.simple_insert_many_txn( File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 923, in simple_insert_many_txn txn.execute_batch(sql, vals) File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 280, in execute_batch self.executemany(sql, args) File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 300, in executemany self._do_execute(self.txn.executemany, sql, args) File "/usr/local/lib/python3.8/site-packages/synapse/storage/database.py", line 330, in _do_execute return func(sql, args) sqlite3.IntegrityError: NOT NULL constraint failed: event_to_state_groups.state_group ``` Revert "Messy: Fix undefined state_group for federated historical events" This reverts commit `187ab28611`. * Fix federated events being rejected for no state_groups Add fix from https://github.com/matrix-org/synapse/pull/10439 until it merges. * Adapting to experimental room version * Some log cleanup * Add better comments around extremity fetching code and why * Rename to be more accurate to what the function returns * Add changelog * Ignore rejected events * Use simplified upsert * Add Erik's explanation of extra event checks See https://github.com/matrix-org/synapse/pull/10498#discussion_r680880332 * Clarify that the depth is not directly correlated to the backwards extremity that we return See https://github.com/matrix-org/synapse/pull/10498#discussion_r681725404 * lock only matters for sqlite See https://github.com/matrix-org/synapse/pull/10498#discussion_r681728061 * Move new SQL changes to its own delta file * Clean up upsert docstring * Bump database schema version (62)	2 years ago
Brendan Abolivier	05111f8f26	Fixup changelog	2 years ago
Brendan Abolivier	cc1cb0ab54	Fixup changelog	2 years ago
Brendan Abolivier	167335bd3d	Fixup changelog	2 years ago
Brendan Abolivier	02c2f631ae	1.40.0rc2	2 years ago
Brendan Abolivier	e8a3e81402	Don't fail on empty bodies when sending out read receipts (#10531 ) Fixes a bug introduced in rc1 that would cause Synapse to 400 on read receipts requests with empty bodies. Broken in #10413	2 years ago
Erik Johnston	c37dad67ab	Improve event caching code (#10119 ) Ensure we only load an event from the DB once when the same event is requested multiple times at once.	2 years ago
Erik Johnston	11540be55e	Fix `could not serialize access` errors for `claim_e2e_one_time_keys` (#10504 )	2 years ago
Jason Robinson	c2000ab35b	Add `get_userinfo_by_id` method to `ModuleApi` (#9581 ) Makes it easier to fetch user details in for example spam checker modules, without needing to use api._store or figure out database interactions. Signed-off-by: Jason Robinson <jasonr@matrix.org>	2 years ago
Kento Okamoto	72935b7c50	Add warnings to ip_range_blacklist usage with proxies (#10129 ) Per issue #9812 using `url_preview_ip_range_blacklist` with a proxy via `HTTPS_PROXY` or `HTTP_PROXY` environment variables has some inconsistent bahavior than mentioned. This PR changes the following: - Changes the Sample Config file to include a note mentioning that `url_preview_ip_range_blacklist` and `ip_range_blacklist` is ignored when using a proxy - Changes some logic in synapse/config/repository.py to send a warning when both `*ip_range_blacklist` configs and a proxy environment variable are set and but no longer throws an error. Signed-off-by: Kento Okamoto <kentokamoto@protonmail.com>	2 years ago
Richard van der Hoff	951648f26a	Fix debian package triggers (#10481 ) Replace the outdated list of dpkg triggers with an autogenerated one.	2 years ago
Richard van der Hoff	4b10880da3	Make sync response cache time configurable. (#10513 )	2 years ago
Dagfinn Ilmari Mannsåker	dc46f12725	Include room ID in ignored EDU log messages (#10507 ) Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>	2 years ago
reivilibre	903db99ed5	Fix PeriodicallyFlushingMemoryHandler inhibiting application shutdown (#10517 )	2 years ago
Erik Johnston	6878e10653	Fix release script URL (#10516 )	2 years ago
Erik Johnston	42225aa421	Fixup changelog	2 years ago
Erik Johnston	da6cd82106	Fixup changelog	2 years ago
Erik Johnston	c80ec5d153	Fixup changelog	2 years ago
Erik Johnston	c8566191fc	1.40.0rc1	2 years ago
reivilibre	f4ac934afe	Revert use of PeriodicallyFlushingMemoryHandler by default (#10515 )	2 years ago
Erik Johnston	a7bacccd85	Extend the release script to tag and create the releases. (#10496 )	2 years ago
Eric Eastwood	2bae2c632f	Add developer documentation to explain room DAG concepts like `outliers` and `state_groups` (#10464 )	2 years ago
Richard van der Hoff	a6ea32a798	Fix the `tests-done` github actions step, again (#10512 )	2 years ago
reivilibre	fb086edaed	Fix codestyle CI from #10440 (#10511 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2 years ago
Erik Johnston	01d45fe964	Prune inbound federation queues if they get too long (#10390 )	2 years ago
Toni Spets	ba5287f5e8	Allow setting transaction limit for db connections (#10440 ) Setting the value will help PostgreSQL free up memory by recycling the connections in the connection pool. Signed-off-by: Toni Spets <toni.spets@iki.fi>	2 years ago

1 2 3 4 5 ...

19207 Commits (eea28735958804cd2b0d54bd19e1e25e8570209d) All Branches Search

19207 Commits (eea28735958804cd2b0d54bd19e1e25e8570209d)

All Branches