You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 

357 lines
14 KiB

  1. # Copyright 2020 The Matrix.org Foundation C.I.C.
  2. #
  3. # Licensed under the Apache License, Version 2.0 (the "License");
  4. # you may not use this file except in compliance with the License.
  5. # You may obtain a copy of the License at
  6. #
  7. # http://www.apache.org/licenses/LICENSE-2.0
  8. #
  9. # Unless required by applicable law or agreed to in writing, software
  10. # distributed under the License is distributed on an "AS IS" BASIS,
  11. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. # See the License for the specific language governing permissions and
  13. # limitations under the License.
  14. from typing import Optional, Union
  15. from unittest.mock import Mock
  16. from twisted.internet.defer import succeed
  17. from twisted.test.proto_helpers import MemoryReactor
  18. from synapse.api.errors import FederationError
  19. from synapse.api.room_versions import RoomVersions
  20. from synapse.events import EventBase, make_event_from_dict
  21. from synapse.events.snapshot import EventContext
  22. from synapse.federation.federation_base import event_from_pdu_json
  23. from synapse.http.types import QueryParams
  24. from synapse.logging.context import LoggingContext
  25. from synapse.server import HomeServer
  26. from synapse.types import JsonDict, UserID, create_requester
  27. from synapse.util import Clock
  28. from synapse.util.retryutils import NotRetryingDestination
  29. from tests import unittest
  30. from tests.test_utils import make_awaitable
  31. class MessageAcceptTests(unittest.HomeserverTestCase):
  32. def make_homeserver(self, reactor: MemoryReactor, clock: Clock) -> HomeServer:
  33. self.http_client = Mock()
  34. return self.setup_test_homeserver(federation_http_client=self.http_client)
  35. def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
  36. user_id = UserID("us", "test")
  37. our_user = create_requester(user_id)
  38. room_creator = self.hs.get_room_creation_handler()
  39. self.room_id = self.get_success(
  40. room_creator.create_room(
  41. our_user, room_creator._presets_dict["public_chat"], ratelimit=False
  42. )
  43. )[0]["room_id"]
  44. self.store = self.hs.get_datastores().main
  45. # Figure out what the most recent event is
  46. most_recent = self.get_success(
  47. self.hs.get_datastores().main.get_latest_event_ids_in_room(self.room_id)
  48. )[0]
  49. join_event = make_event_from_dict(
  50. {
  51. "room_id": self.room_id,
  52. "sender": "@baduser:test.serv",
  53. "state_key": "@baduser:test.serv",
  54. "event_id": "$join:test.serv",
  55. "depth": 1000,
  56. "origin_server_ts": 1,
  57. "type": "m.room.member",
  58. "origin": "test.servx",
  59. "content": {"membership": "join"},
  60. "auth_events": [],
  61. "prev_state": [(most_recent, {})],
  62. "prev_events": [(most_recent, {})],
  63. }
  64. )
  65. self.handler = self.hs.get_federation_handler()
  66. federation_event_handler = self.hs.get_federation_event_handler()
  67. async def _check_event_auth(
  68. origin: Optional[str], event: EventBase, context: EventContext
  69. ) -> None:
  70. pass
  71. federation_event_handler._check_event_auth = _check_event_auth
  72. self.client = self.hs.get_federation_client()
  73. self.client._check_sigs_and_hash_for_pulled_events_and_fetch = (
  74. lambda dest, pdus, **k: succeed(pdus)
  75. )
  76. # Send the join, it should return None (which is not an error)
  77. self.assertEqual(
  78. self.get_success(
  79. federation_event_handler.on_receive_pdu("test.serv", join_event)
  80. ),
  81. None,
  82. )
  83. # Make sure we actually joined the room
  84. self.assertEqual(
  85. self.get_success(self.store.get_latest_event_ids_in_room(self.room_id))[0],
  86. "$join:test.serv",
  87. )
  88. def test_cant_hide_direct_ancestors(self) -> None:
  89. """
  90. If you send a message, you must be able to provide the direct
  91. prev_events that said event references.
  92. """
  93. async def post_json(
  94. destination: str,
  95. path: str,
  96. data: Optional[JsonDict] = None,
  97. long_retries: bool = False,
  98. timeout: Optional[int] = None,
  99. ignore_backoff: bool = False,
  100. args: Optional[QueryParams] = None,
  101. ) -> Union[JsonDict, list]:
  102. # If it asks us for new missing events, give them NOTHING
  103. if path.startswith("/_matrix/federation/v1/get_missing_events/"):
  104. return {"events": []}
  105. return {}
  106. self.http_client.post_json = post_json
  107. # Figure out what the most recent event is
  108. most_recent = self.get_success(
  109. self.store.get_latest_event_ids_in_room(self.room_id)
  110. )[0]
  111. # Now lie about an event
  112. lying_event = make_event_from_dict(
  113. {
  114. "room_id": self.room_id,
  115. "sender": "@baduser:test.serv",
  116. "event_id": "one:test.serv",
  117. "depth": 1000,
  118. "origin_server_ts": 1,
  119. "type": "m.room.message",
  120. "origin": "test.serv",
  121. "content": {"body": "hewwo?"},
  122. "auth_events": [],
  123. "prev_events": [("two:test.serv", {}), (most_recent, {})],
  124. }
  125. )
  126. federation_event_handler = self.hs.get_federation_event_handler()
  127. with LoggingContext("test-context"):
  128. failure = self.get_failure(
  129. federation_event_handler.on_receive_pdu("test.serv", lying_event),
  130. FederationError,
  131. )
  132. # on_receive_pdu should throw an error
  133. self.assertEqual(
  134. failure.value.args[0],
  135. (
  136. "ERROR 403: Your server isn't divulging details about prev_events "
  137. "referenced in this event."
  138. ),
  139. )
  140. # Make sure the invalid event isn't there
  141. extrem = self.get_success(self.store.get_latest_event_ids_in_room(self.room_id))
  142. self.assertEqual(extrem[0], "$join:test.serv")
  143. def test_retry_device_list_resync(self) -> None:
  144. """Tests that device lists are marked as stale if they couldn't be synced, and
  145. that stale device lists are retried periodically.
  146. """
  147. remote_user_id = "@john:test_remote"
  148. remote_origin = "test_remote"
  149. # Track the number of attempts to resync the user's device list.
  150. self.resync_attempts = 0
  151. # When this function is called, increment the number of resync attempts (only if
  152. # we're querying devices for the right user ID), then raise a
  153. # NotRetryingDestination error to fail the resync gracefully.
  154. def query_user_devices(
  155. destination: str, user_id: str, timeout: int = 30000
  156. ) -> JsonDict:
  157. if user_id == remote_user_id:
  158. self.resync_attempts += 1
  159. raise NotRetryingDestination(0, 0, destination)
  160. # Register the mock on the federation client.
  161. federation_client = self.hs.get_federation_client()
  162. federation_client.query_user_devices = Mock(side_effect=query_user_devices)
  163. # Register a mock on the store so that the incoming update doesn't fail because
  164. # we don't share a room with the user.
  165. store = self.hs.get_datastores().main
  166. store.get_rooms_for_user = Mock(return_value=make_awaitable(["!someroom:test"]))
  167. # Manually inject a fake device list update. We need this update to include at
  168. # least one prev_id so that the user's device list will need to be retried.
  169. device_list_updater = self.hs.get_device_handler().device_list_updater
  170. self.get_success(
  171. device_list_updater.incoming_device_list_update(
  172. origin=remote_origin,
  173. edu_content={
  174. "deleted": False,
  175. "device_display_name": "Mobile",
  176. "device_id": "QBUAZIFURK",
  177. "prev_id": [5],
  178. "stream_id": 6,
  179. "user_id": remote_user_id,
  180. },
  181. )
  182. )
  183. # Check that there was one resync attempt.
  184. self.assertEqual(self.resync_attempts, 1)
  185. # Check that the resync attempt failed and caused the user's device list to be
  186. # marked as stale.
  187. need_resync = self.get_success(
  188. store.get_user_ids_requiring_device_list_resync()
  189. )
  190. self.assertIn(remote_user_id, need_resync)
  191. # Check that waiting for 30 seconds caused Synapse to retry resyncing the device
  192. # list.
  193. self.reactor.advance(30)
  194. self.assertEqual(self.resync_attempts, 2)
  195. def test_cross_signing_keys_retry(self) -> None:
  196. """Tests that resyncing a device list correctly processes cross-signing keys from
  197. the remote server.
  198. """
  199. remote_user_id = "@john:test_remote"
  200. remote_master_key = "85T7JXPFBAySB/jwby4S3lBPTqY3+Zg53nYuGmu1ggY"
  201. remote_self_signing_key = "QeIiFEjluPBtI7WQdG365QKZcFs9kqmHir6RBD0//nQ"
  202. # Register mock device list retrieval on the federation client.
  203. federation_client = self.hs.get_federation_client()
  204. federation_client.query_user_devices = Mock(
  205. return_value=make_awaitable(
  206. {
  207. "user_id": remote_user_id,
  208. "stream_id": 1,
  209. "devices": [],
  210. "master_key": {
  211. "user_id": remote_user_id,
  212. "usage": ["master"],
  213. "keys": {"ed25519:" + remote_master_key: remote_master_key},
  214. },
  215. "self_signing_key": {
  216. "user_id": remote_user_id,
  217. "usage": ["self_signing"],
  218. "keys": {
  219. "ed25519:"
  220. + remote_self_signing_key: remote_self_signing_key
  221. },
  222. },
  223. }
  224. )
  225. )
  226. # Resync the device list.
  227. device_handler = self.hs.get_device_handler()
  228. self.get_success(
  229. device_handler.device_list_updater.user_device_resync(remote_user_id),
  230. )
  231. # Retrieve the cross-signing keys for this user.
  232. keys = self.get_success(
  233. self.store.get_e2e_cross_signing_keys_bulk(user_ids=[remote_user_id]),
  234. )
  235. self.assertTrue(remote_user_id in keys)
  236. # Check that the master key is the one returned by the mock.
  237. master_key = keys[remote_user_id]["master"]
  238. self.assertEqual(len(master_key["keys"]), 1)
  239. self.assertTrue("ed25519:" + remote_master_key in master_key["keys"].keys())
  240. self.assertTrue(remote_master_key in master_key["keys"].values())
  241. # Check that the self-signing key is the one returned by the mock.
  242. self_signing_key = keys[remote_user_id]["self_signing"]
  243. self.assertEqual(len(self_signing_key["keys"]), 1)
  244. self.assertTrue(
  245. "ed25519:" + remote_self_signing_key in self_signing_key["keys"].keys(),
  246. )
  247. self.assertTrue(remote_self_signing_key in self_signing_key["keys"].values())
  248. class StripUnsignedFromEventsTestCase(unittest.TestCase):
  249. def test_strip_unauthorized_unsigned_values(self) -> None:
  250. event1 = {
  251. "sender": "@baduser:test.serv",
  252. "state_key": "@baduser:test.serv",
  253. "event_id": "$event1:test.serv",
  254. "depth": 1000,
  255. "origin_server_ts": 1,
  256. "type": "m.room.member",
  257. "origin": "test.servx",
  258. "content": {"membership": "join"},
  259. "auth_events": [],
  260. "unsigned": {"malicious garbage": "hackz", "more warez": "more hackz"},
  261. }
  262. filtered_event = event_from_pdu_json(event1, RoomVersions.V1)
  263. # Make sure unauthorized fields are stripped from unsigned
  264. self.assertNotIn("more warez", filtered_event.unsigned)
  265. def test_strip_event_maintains_allowed_fields(self) -> None:
  266. event2 = {
  267. "sender": "@baduser:test.serv",
  268. "state_key": "@baduser:test.serv",
  269. "event_id": "$event2:test.serv",
  270. "depth": 1000,
  271. "origin_server_ts": 1,
  272. "type": "m.room.member",
  273. "origin": "test.servx",
  274. "auth_events": [],
  275. "content": {"membership": "join"},
  276. "unsigned": {
  277. "malicious garbage": "hackz",
  278. "more warez": "more hackz",
  279. "age": 14,
  280. "invite_room_state": [],
  281. },
  282. }
  283. filtered_event2 = event_from_pdu_json(event2, RoomVersions.V1)
  284. self.assertIn("age", filtered_event2.unsigned)
  285. self.assertEqual(14, filtered_event2.unsigned["age"])
  286. self.assertNotIn("more warez", filtered_event2.unsigned)
  287. # Invite_room_state is allowed in events of type m.room.member
  288. self.assertIn("invite_room_state", filtered_event2.unsigned)
  289. self.assertEqual([], filtered_event2.unsigned["invite_room_state"])
  290. def test_strip_event_removes_fields_based_on_event_type(self) -> None:
  291. event3 = {
  292. "sender": "@baduser:test.serv",
  293. "state_key": "@baduser:test.serv",
  294. "event_id": "$event3:test.serv",
  295. "depth": 1000,
  296. "origin_server_ts": 1,
  297. "type": "m.room.power_levels",
  298. "origin": "test.servx",
  299. "content": {},
  300. "auth_events": [],
  301. "unsigned": {
  302. "malicious garbage": "hackz",
  303. "more warez": "more hackz",
  304. "age": 14,
  305. "invite_room_state": [],
  306. },
  307. }
  308. filtered_event3 = event_from_pdu_json(event3, RoomVersions.V1)
  309. self.assertIn("age", filtered_event3.unsigned)
  310. # Invite_room_state field is only permitted in event type m.room.member
  311. self.assertNotIn("invite_room_state", filtered_event3.unsigned)
  312. self.assertNotIn("more warez", filtered_event3.unsigned)