You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 

309 rivejä
11 KiB

  1. # -*- coding: utf-8 -*-
  2. # Copyright 2018 New Vector Ltd
  3. #
  4. # Licensed under the Apache License, Version 2.0 (the "License");
  5. # you may not use this file except in compliance with the License.
  6. # You may obtain a copy of the License at
  7. #
  8. # http://www.apache.org/licenses/LICENSE-2.0
  9. #
  10. # Unless required by applicable law or agreed to in writing, software
  11. # distributed under the License is distributed on an "AS IS" BASIS,
  12. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13. # See the License for the specific language governing permissions and
  14. # limitations under the License.
  15. import hashlib
  16. import hmac
  17. import json
  18. from mock import Mock
  19. from synapse.http.server import JsonResource
  20. from synapse.rest.client.v1.admin import register_servlets
  21. from synapse.util import Clock
  22. from tests import unittest
  23. from tests.server import (
  24. ThreadedMemoryReactorClock,
  25. make_request,
  26. render,
  27. setup_test_homeserver,
  28. )
  29. class UserRegisterTestCase(unittest.TestCase):
  30. def setUp(self):
  31. self.clock = ThreadedMemoryReactorClock()
  32. self.hs_clock = Clock(self.clock)
  33. self.url = "/_matrix/client/r0/admin/register"
  34. self.registration_handler = Mock()
  35. self.identity_handler = Mock()
  36. self.login_handler = Mock()
  37. self.device_handler = Mock()
  38. self.device_handler.check_device_registered = Mock(return_value="FAKE")
  39. self.datastore = Mock(return_value=Mock())
  40. self.datastore.get_current_state_deltas = Mock(return_value=[])
  41. self.secrets = Mock()
  42. self.hs = setup_test_homeserver(
  43. self.addCleanup, http_client=None, clock=self.hs_clock, reactor=self.clock
  44. )
  45. self.hs.config.registration_shared_secret = u"shared"
  46. self.hs.get_media_repository = Mock()
  47. self.hs.get_deactivate_account_handler = Mock()
  48. self.resource = JsonResource(self.hs)
  49. register_servlets(self.hs, self.resource)
  50. def test_disabled(self):
  51. """
  52. If there is no shared secret, registration through this method will be
  53. prevented.
  54. """
  55. self.hs.config.registration_shared_secret = None
  56. request, channel = make_request("POST", self.url, b'{}')
  57. render(request, self.resource, self.clock)
  58. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  59. self.assertEqual(
  60. 'Shared secret registration is not enabled', channel.json_body["error"]
  61. )
  62. def test_get_nonce(self):
  63. """
  64. Calling GET on the endpoint will return a randomised nonce, using the
  65. homeserver's secrets provider.
  66. """
  67. secrets = Mock()
  68. secrets.token_hex = Mock(return_value="abcd")
  69. self.hs.get_secrets = Mock(return_value=secrets)
  70. request, channel = make_request("GET", self.url)
  71. render(request, self.resource, self.clock)
  72. self.assertEqual(channel.json_body, {"nonce": "abcd"})
  73. def test_expired_nonce(self):
  74. """
  75. Calling GET on the endpoint will return a randomised nonce, which will
  76. only last for SALT_TIMEOUT (60s).
  77. """
  78. request, channel = make_request("GET", self.url)
  79. render(request, self.resource, self.clock)
  80. nonce = channel.json_body["nonce"]
  81. # 59 seconds
  82. self.clock.advance(59)
  83. body = json.dumps({"nonce": nonce})
  84. request, channel = make_request("POST", self.url, body.encode('utf8'))
  85. render(request, self.resource, self.clock)
  86. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  87. self.assertEqual('username must be specified', channel.json_body["error"])
  88. # 61 seconds
  89. self.clock.advance(2)
  90. request, channel = make_request("POST", self.url, body.encode('utf8'))
  91. render(request, self.resource, self.clock)
  92. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  93. self.assertEqual('unrecognised nonce', channel.json_body["error"])
  94. def test_register_incorrect_nonce(self):
  95. """
  96. Only the provided nonce can be used, as it's checked in the MAC.
  97. """
  98. request, channel = make_request("GET", self.url)
  99. render(request, self.resource, self.clock)
  100. nonce = channel.json_body["nonce"]
  101. want_mac = hmac.new(key=b"shared", digestmod=hashlib.sha1)
  102. want_mac.update(b"notthenonce\x00bob\x00abc123\x00admin")
  103. want_mac = want_mac.hexdigest()
  104. body = json.dumps(
  105. {
  106. "nonce": nonce,
  107. "username": "bob",
  108. "password": "abc123",
  109. "admin": True,
  110. "mac": want_mac,
  111. }
  112. )
  113. request, channel = make_request("POST", self.url, body.encode('utf8'))
  114. render(request, self.resource, self.clock)
  115. self.assertEqual(403, int(channel.result["code"]), msg=channel.result["body"])
  116. self.assertEqual("HMAC incorrect", channel.json_body["error"])
  117. def test_register_correct_nonce(self):
  118. """
  119. When the correct nonce is provided, and the right key is provided, the
  120. user is registered.
  121. """
  122. request, channel = make_request("GET", self.url)
  123. render(request, self.resource, self.clock)
  124. nonce = channel.json_body["nonce"]
  125. want_mac = hmac.new(key=b"shared", digestmod=hashlib.sha1)
  126. want_mac.update(nonce.encode('ascii') + b"\x00bob\x00abc123\x00admin")
  127. want_mac = want_mac.hexdigest()
  128. body = json.dumps(
  129. {
  130. "nonce": nonce,
  131. "username": "bob",
  132. "password": "abc123",
  133. "admin": True,
  134. "mac": want_mac,
  135. }
  136. )
  137. request, channel = make_request("POST", self.url, body.encode('utf8'))
  138. render(request, self.resource, self.clock)
  139. self.assertEqual(200, int(channel.result["code"]), msg=channel.result["body"])
  140. self.assertEqual("@bob:test", channel.json_body["user_id"])
  141. def test_nonce_reuse(self):
  142. """
  143. A valid unrecognised nonce.
  144. """
  145. request, channel = make_request("GET", self.url)
  146. render(request, self.resource, self.clock)
  147. nonce = channel.json_body["nonce"]
  148. want_mac = hmac.new(key=b"shared", digestmod=hashlib.sha1)
  149. want_mac.update(nonce.encode('ascii') + b"\x00bob\x00abc123\x00admin")
  150. want_mac = want_mac.hexdigest()
  151. body = json.dumps(
  152. {
  153. "nonce": nonce,
  154. "username": "bob",
  155. "password": "abc123",
  156. "admin": True,
  157. "mac": want_mac,
  158. }
  159. )
  160. request, channel = make_request("POST", self.url, body.encode('utf8'))
  161. render(request, self.resource, self.clock)
  162. self.assertEqual(200, int(channel.result["code"]), msg=channel.result["body"])
  163. self.assertEqual("@bob:test", channel.json_body["user_id"])
  164. # Now, try and reuse it
  165. request, channel = make_request("POST", self.url, body.encode('utf8'))
  166. render(request, self.resource, self.clock)
  167. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  168. self.assertEqual('unrecognised nonce', channel.json_body["error"])
  169. def test_missing_parts(self):
  170. """
  171. Synapse will complain if you don't give nonce, username, password, and
  172. mac. Admin is optional. Additional checks are done for length and
  173. type.
  174. """
  175. def nonce():
  176. request, channel = make_request("GET", self.url)
  177. render(request, self.resource, self.clock)
  178. return channel.json_body["nonce"]
  179. #
  180. # Nonce check
  181. #
  182. # Must be present
  183. body = json.dumps({})
  184. request, channel = make_request("POST", self.url, body.encode('utf8'))
  185. render(request, self.resource, self.clock)
  186. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  187. self.assertEqual('nonce must be specified', channel.json_body["error"])
  188. #
  189. # Username checks
  190. #
  191. # Must be present
  192. body = json.dumps({"nonce": nonce()})
  193. request, channel = make_request("POST", self.url, body.encode('utf8'))
  194. render(request, self.resource, self.clock)
  195. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  196. self.assertEqual('username must be specified', channel.json_body["error"])
  197. # Must be a string
  198. body = json.dumps({"nonce": nonce(), "username": 1234})
  199. request, channel = make_request("POST", self.url, body.encode('utf8'))
  200. render(request, self.resource, self.clock)
  201. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  202. self.assertEqual('Invalid username', channel.json_body["error"])
  203. # Must not have null bytes
  204. body = json.dumps({"nonce": nonce(), "username": u"abcd\u0000"})
  205. request, channel = make_request("POST", self.url, body.encode('utf8'))
  206. render(request, self.resource, self.clock)
  207. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  208. self.assertEqual('Invalid username', channel.json_body["error"])
  209. # Must not have null bytes
  210. body = json.dumps({"nonce": nonce(), "username": "a" * 1000})
  211. request, channel = make_request("POST", self.url, body.encode('utf8'))
  212. render(request, self.resource, self.clock)
  213. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  214. self.assertEqual('Invalid username', channel.json_body["error"])
  215. #
  216. # Username checks
  217. #
  218. # Must be present
  219. body = json.dumps({"nonce": nonce(), "username": "a"})
  220. request, channel = make_request("POST", self.url, body.encode('utf8'))
  221. render(request, self.resource, self.clock)
  222. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  223. self.assertEqual('password must be specified', channel.json_body["error"])
  224. # Must be a string
  225. body = json.dumps({"nonce": nonce(), "username": "a", "password": 1234})
  226. request, channel = make_request("POST", self.url, body.encode('utf8'))
  227. render(request, self.resource, self.clock)
  228. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  229. self.assertEqual('Invalid password', channel.json_body["error"])
  230. # Must not have null bytes
  231. body = json.dumps(
  232. {"nonce": nonce(), "username": "a", "password": u"abcd\u0000"}
  233. )
  234. request, channel = make_request("POST", self.url, body.encode('utf8'))
  235. render(request, self.resource, self.clock)
  236. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  237. self.assertEqual('Invalid password', channel.json_body["error"])
  238. # Super long
  239. body = json.dumps({"nonce": nonce(), "username": "a", "password": "A" * 1000})
  240. request, channel = make_request("POST", self.url, body.encode('utf8'))
  241. render(request, self.resource, self.clock)
  242. self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"])
  243. self.assertEqual('Invalid password', channel.json_body["error"])