You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 

1591 lines
57 KiB

  1. # Copyright 2019 New Vector Ltd
  2. #
  3. # Licensed under the Apache License, Version 2.0 (the "License");
  4. # you may not use this file except in compliance with the License.
  5. # You may obtain a copy of the License at
  6. #
  7. # http://www.apache.org/licenses/LICENSE-2.0
  8. #
  9. # Unless required by applicable law or agreed to in writing, software
  10. # distributed under the License is distributed on an "AS IS" BASIS,
  11. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. # See the License for the specific language governing permissions and
  13. # limitations under the License.
  14. import base64
  15. import logging
  16. import os
  17. from typing import Any, Awaitable, Callable, Generator, List, Optional, cast
  18. from unittest.mock import Mock, patch
  19. import treq
  20. from netaddr import IPSet
  21. from service_identity import VerificationError
  22. from zope.interface import implementer
  23. from twisted.internet import defer
  24. from twisted.internet._sslverify import ClientTLSOptions, OpenSSLCertificateOptions
  25. from twisted.internet.defer import Deferred
  26. from twisted.internet.endpoints import _WrappingProtocol
  27. from twisted.internet.interfaces import (
  28. IOpenSSLClientConnectionCreator,
  29. IProtocolFactory,
  30. )
  31. from twisted.internet.protocol import Factory, Protocol
  32. from twisted.protocols.tls import TLSMemoryBIOFactory, TLSMemoryBIOProtocol
  33. from twisted.web._newclient import ResponseNeverReceived
  34. from twisted.web.client import Agent
  35. from twisted.web.http import HTTPChannel, Request
  36. from twisted.web.http_headers import Headers
  37. from twisted.web.iweb import IPolicyForHTTPS, IResponse
  38. from synapse.config.homeserver import HomeServerConfig
  39. from synapse.crypto.context_factory import FederationPolicyForHTTPS
  40. from synapse.http.federation.matrix_federation_agent import MatrixFederationAgent
  41. from synapse.http.federation.srv_resolver import Server
  42. from synapse.http.federation.well_known_resolver import (
  43. WELL_KNOWN_MAX_SIZE,
  44. WellKnownResolver,
  45. _cache_period_from_headers,
  46. )
  47. from synapse.logging.context import (
  48. SENTINEL_CONTEXT,
  49. LoggingContext,
  50. LoggingContextOrSentinel,
  51. current_context,
  52. )
  53. from synapse.types import ISynapseReactor
  54. from synapse.util.caches.ttlcache import TTLCache
  55. from tests import unittest
  56. from tests.http import (
  57. TestServerTLSConnectionFactory,
  58. dummy_address,
  59. get_test_ca_cert_file,
  60. )
  61. from tests.server import FakeTransport, ThreadedMemoryReactorClock
  62. from tests.utils import checked_cast, default_config
  63. logger = logging.getLogger(__name__)
  64. # Once Async Mocks or lambdas are supported this can go away.
  65. def generate_resolve_service(
  66. result: List[Server],
  67. ) -> Callable[[Any], Awaitable[List[Server]]]:
  68. async def resolve_service(_: Any) -> List[Server]:
  69. return result
  70. return resolve_service
  71. class MatrixFederationAgentTests(unittest.TestCase):
  72. def setUp(self) -> None:
  73. self.reactor = ThreadedMemoryReactorClock()
  74. self.mock_resolver = Mock()
  75. config_dict = default_config("test", parse=False)
  76. config_dict["federation_custom_ca_list"] = [get_test_ca_cert_file()]
  77. self._config = config = HomeServerConfig()
  78. config.parse_config_dict(config_dict, "", "")
  79. self.tls_factory = FederationPolicyForHTTPS(config)
  80. self.well_known_cache: TTLCache[bytes, Optional[bytes]] = TTLCache(
  81. "test_cache", timer=self.reactor.seconds
  82. )
  83. self.had_well_known_cache: TTLCache[bytes, bool] = TTLCache(
  84. "test_cache", timer=self.reactor.seconds
  85. )
  86. self.well_known_resolver = WellKnownResolver(
  87. self.reactor,
  88. Agent(self.reactor, contextFactory=self.tls_factory),
  89. b"test-agent",
  90. well_known_cache=self.well_known_cache,
  91. had_well_known_cache=self.had_well_known_cache,
  92. )
  93. def _make_connection(
  94. self,
  95. client_factory: IProtocolFactory,
  96. ssl: bool = True,
  97. expected_sni: Optional[bytes] = None,
  98. tls_sanlist: Optional[List[bytes]] = None,
  99. ) -> HTTPChannel:
  100. """Builds a test server, and completes the outgoing client connection
  101. Args:
  102. client_factory: the the factory that the
  103. application is trying to use to make the outbound connection. We will
  104. invoke it to build the client Protocol
  105. ssl: If true, we will expect an ssl connection and wrap
  106. server_factory with a TLSMemoryBIOFactory
  107. False is set only for when proxy expect http connection.
  108. Otherwise federation requests use always https.
  109. expected_sni: the expected SNI value
  110. tls_sanlist: list of SAN entries for the TLS cert presented by the server.
  111. Returns:
  112. the server Protocol returned by server_factory
  113. """
  114. # build the test server
  115. server_factory = _get_test_protocol_factory()
  116. if ssl:
  117. server_factory = _wrap_server_factory_for_tls(server_factory, tls_sanlist)
  118. server_protocol = server_factory.buildProtocol(dummy_address)
  119. assert server_protocol is not None
  120. # now, tell the client protocol factory to build the client protocol (it will be a
  121. # _WrappingProtocol, around a TLSMemoryBIOProtocol, around an
  122. # HTTP11ClientProtocol) and wire the output of said protocol up to the server via
  123. # a FakeTransport.
  124. #
  125. # Normally this would be done by the TCP socket code in Twisted, but we are
  126. # stubbing that out here.
  127. # NB: we use a checked_cast here to workaround https://github.com/Shoobx/mypy-zope/issues/91)
  128. client_protocol = checked_cast(
  129. _WrappingProtocol, client_factory.buildProtocol(dummy_address)
  130. )
  131. client_protocol.makeConnection(
  132. FakeTransport(server_protocol, self.reactor, client_protocol)
  133. )
  134. # tell the server protocol to send its stuff back to the client, too
  135. server_protocol.makeConnection(
  136. FakeTransport(client_protocol, self.reactor, server_protocol)
  137. )
  138. if ssl:
  139. assert isinstance(server_protocol, TLSMemoryBIOProtocol)
  140. # fish the test server back out of the server-side TLS protocol.
  141. http_protocol = server_protocol.wrappedProtocol
  142. # grab a hold of the TLS connection, in case it gets torn down
  143. tls_connection = server_protocol._tlsConnection
  144. else:
  145. http_protocol = server_protocol
  146. tls_connection = None
  147. assert isinstance(http_protocol, HTTPChannel)
  148. # give the reactor a pump to get the TLS juices flowing (if needed)
  149. self.reactor.advance(0)
  150. # check the SNI
  151. if expected_sni is not None:
  152. server_name = tls_connection.get_servername()
  153. self.assertEqual(
  154. server_name,
  155. expected_sni,
  156. f"Expected SNI {expected_sni!s} but got {server_name!s}",
  157. )
  158. return http_protocol
  159. @defer.inlineCallbacks
  160. def _make_get_request(
  161. self, uri: bytes
  162. ) -> Generator["Deferred[object]", object, IResponse]:
  163. """
  164. Sends a simple GET request via the agent, and checks its logcontext management
  165. """
  166. with LoggingContext("one") as context:
  167. fetch_d: Deferred[IResponse] = self.agent.request(b"GET", uri)
  168. # Nothing happened yet
  169. self.assertNoResult(fetch_d)
  170. # should have reset logcontext to the sentinel
  171. _check_logcontext(SENTINEL_CONTEXT)
  172. fetch_res: IResponse
  173. try:
  174. fetch_res = yield fetch_d # type: ignore[misc, assignment]
  175. return fetch_res
  176. except Exception as e:
  177. logger.info("Fetch of %s failed: %s", uri.decode("ascii"), e)
  178. raise
  179. finally:
  180. _check_logcontext(context)
  181. def _handle_well_known_connection(
  182. self,
  183. client_factory: IProtocolFactory,
  184. expected_sni: bytes,
  185. content: bytes,
  186. response_headers: Optional[dict] = None,
  187. ) -> HTTPChannel:
  188. """Handle an outgoing HTTPs connection: wire it up to a server, check that the
  189. request is for a .well-known, and send the response.
  190. Args:
  191. client_factory: outgoing connection
  192. expected_sni: SNI that we expect the outgoing connection to send
  193. content: content to send back as the .well-known
  194. Returns:
  195. server impl
  196. """
  197. # make the connection for .well-known
  198. well_known_server = self._make_connection(
  199. client_factory, expected_sni=expected_sni
  200. )
  201. # check the .well-known request and send a response
  202. self.assertEqual(len(well_known_server.requests), 1)
  203. request = well_known_server.requests[0]
  204. self.assertEqual(
  205. request.requestHeaders.getRawHeaders(b"user-agent"), [b"test-agent"]
  206. )
  207. self._send_well_known_response(request, content, headers=response_headers or {})
  208. return well_known_server
  209. def _send_well_known_response(
  210. self,
  211. request: Request,
  212. content: bytes,
  213. headers: Optional[dict] = None,
  214. ) -> None:
  215. """Check that an incoming request looks like a valid .well-known request, and
  216. send back the response.
  217. """
  218. self.assertEqual(request.method, b"GET")
  219. self.assertEqual(request.path, b"/.well-known/matrix/server")
  220. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"testserv"])
  221. # send back a response
  222. for k, v in (headers or {}).items():
  223. request.setHeader(k, v)
  224. request.write(content)
  225. request.finish()
  226. self.reactor.pump((0.1,))
  227. def _make_agent(self) -> MatrixFederationAgent:
  228. """
  229. If a proxy server is set, the MatrixFederationAgent must be created again
  230. because it is created too early during setUp
  231. """
  232. return MatrixFederationAgent(
  233. reactor=cast(ISynapseReactor, self.reactor),
  234. tls_client_options_factory=self.tls_factory,
  235. user_agent=b"test-agent", # Note that this is unused since _well_known_resolver is provided.
  236. ip_allowlist=IPSet(),
  237. ip_blocklist=IPSet(),
  238. _srv_resolver=self.mock_resolver,
  239. _well_known_resolver=self.well_known_resolver,
  240. )
  241. def test_get(self) -> None:
  242. """happy-path test of a GET request with an explicit port"""
  243. self._do_get()
  244. @patch.dict(
  245. os.environ,
  246. {"https_proxy": "proxy.com", "no_proxy": "testserv"},
  247. )
  248. def test_get_bypass_proxy(self) -> None:
  249. """test of a GET request with an explicit port and bypass proxy"""
  250. self._do_get()
  251. def _do_get(self) -> None:
  252. """test of a GET request with an explicit port"""
  253. self.agent = self._make_agent()
  254. self.reactor.lookups["testserv"] = "1.2.3.4"
  255. test_d = self._make_get_request(b"matrix-federation://testserv:8448/foo/bar")
  256. # Nothing happened yet
  257. self.assertNoResult(test_d)
  258. # Make sure treq is trying to connect
  259. clients = self.reactor.tcpClients
  260. self.assertEqual(len(clients), 1)
  261. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  262. self.assertEqual(host, "1.2.3.4")
  263. self.assertEqual(port, 8448)
  264. # make a test server, and wire up the client
  265. http_server = self._make_connection(client_factory, expected_sni=b"testserv")
  266. self.assertEqual(len(http_server.requests), 1)
  267. request = http_server.requests[0]
  268. self.assertEqual(request.method, b"GET")
  269. self.assertEqual(request.path, b"/foo/bar")
  270. self.assertEqual(
  271. request.requestHeaders.getRawHeaders(b"host"), [b"testserv:8448"]
  272. )
  273. self.assertEqual(
  274. request.requestHeaders.getRawHeaders(b"user-agent"), [b"test-agent"]
  275. )
  276. content = request.content.read()
  277. self.assertEqual(content, b"")
  278. # Deferred is still without a result
  279. self.assertNoResult(test_d)
  280. # send the headers
  281. request.responseHeaders.setRawHeaders(b"Content-Type", [b"application/json"])
  282. request.write("")
  283. self.reactor.pump((0.1,))
  284. response = self.successResultOf(test_d)
  285. # that should give us a Response object
  286. self.assertEqual(response.code, 200)
  287. # Send the body
  288. request.write(b'{ "a": 1 }')
  289. request.finish()
  290. self.reactor.pump((0.1,))
  291. # check it can be read
  292. json = self.successResultOf(treq.json_content(response))
  293. self.assertEqual(json, {"a": 1})
  294. @patch.dict(
  295. os.environ, {"https_proxy": "http://proxy.com", "no_proxy": "unused.com"}
  296. )
  297. def test_get_via_http_proxy(self) -> None:
  298. """test for federation request through a http proxy"""
  299. self._do_get_via_proxy(expect_proxy_ssl=False, expected_auth_credentials=None)
  300. @patch.dict(
  301. os.environ,
  302. {"https_proxy": "http://user:pass@proxy.com", "no_proxy": "unused.com"},
  303. )
  304. def test_get_via_http_proxy_with_auth(self) -> None:
  305. """test for federation request through a http proxy with authentication"""
  306. self._do_get_via_proxy(
  307. expect_proxy_ssl=False, expected_auth_credentials=b"user:pass"
  308. )
  309. @patch.dict(
  310. os.environ, {"https_proxy": "https://proxy.com", "no_proxy": "unused.com"}
  311. )
  312. def test_get_via_https_proxy(self) -> None:
  313. """test for federation request through a https proxy"""
  314. self._do_get_via_proxy(expect_proxy_ssl=True, expected_auth_credentials=None)
  315. @patch.dict(
  316. os.environ,
  317. {"https_proxy": "https://user:pass@proxy.com", "no_proxy": "unused.com"},
  318. )
  319. def test_get_via_https_proxy_with_auth(self) -> None:
  320. """test for federation request through a https proxy with authentication"""
  321. self._do_get_via_proxy(
  322. expect_proxy_ssl=True, expected_auth_credentials=b"user:pass"
  323. )
  324. def _do_get_via_proxy(
  325. self,
  326. expect_proxy_ssl: bool = False,
  327. expected_auth_credentials: Optional[bytes] = None,
  328. ) -> None:
  329. """Send a https federation request via an agent and check that it is correctly
  330. received at the proxy and client. The proxy can use either http or https.
  331. Args:
  332. expect_proxy_ssl: True if we expect the request to connect to the proxy via https.
  333. expected_auth_credentials: credentials we expect to be presented to authenticate at the proxy
  334. """
  335. self.agent = self._make_agent()
  336. self.reactor.lookups["testserv"] = "1.2.3.4"
  337. self.reactor.lookups["proxy.com"] = "9.9.9.9"
  338. test_d = self._make_get_request(b"matrix-federation://testserv:8448/foo/bar")
  339. # Nothing happened yet
  340. self.assertNoResult(test_d)
  341. # Make sure treq is trying to connect
  342. clients = self.reactor.tcpClients
  343. self.assertEqual(len(clients), 1)
  344. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  345. # make sure we are connecting to the proxy
  346. self.assertEqual(host, "9.9.9.9")
  347. self.assertEqual(port, 1080)
  348. # make a test server to act as the proxy, and wire up the client
  349. proxy_server = self._make_connection(
  350. client_factory,
  351. ssl=expect_proxy_ssl,
  352. tls_sanlist=[b"DNS:proxy.com"] if expect_proxy_ssl else None,
  353. expected_sni=b"proxy.com" if expect_proxy_ssl else None,
  354. )
  355. assert isinstance(proxy_server, HTTPChannel)
  356. # now there should be a pending CONNECT request
  357. self.assertEqual(len(proxy_server.requests), 1)
  358. request = proxy_server.requests[0]
  359. self.assertEqual(request.method, b"CONNECT")
  360. self.assertEqual(request.path, b"testserv:8448")
  361. # Check whether auth credentials have been supplied to the proxy
  362. proxy_auth_header_values = request.requestHeaders.getRawHeaders(
  363. b"Proxy-Authorization"
  364. )
  365. if expected_auth_credentials is not None:
  366. # Compute the correct header value for Proxy-Authorization
  367. encoded_credentials = base64.b64encode(expected_auth_credentials)
  368. expected_header_value = b"Basic " + encoded_credentials
  369. # Validate the header's value
  370. self.assertIn(expected_header_value, proxy_auth_header_values)
  371. else:
  372. # Check that the Proxy-Authorization header has not been supplied to the proxy
  373. self.assertIsNone(proxy_auth_header_values)
  374. # tell the proxy server not to close the connection
  375. proxy_server.persistent = True
  376. request.finish()
  377. # now we make another test server to act as the upstream HTTP server.
  378. server_ssl_protocol = _wrap_server_factory_for_tls(
  379. _get_test_protocol_factory()
  380. ).buildProtocol(dummy_address)
  381. # Tell the HTTP server to send outgoing traffic back via the proxy's transport.
  382. proxy_server_transport = proxy_server.transport
  383. assert proxy_server_transport is not None
  384. server_ssl_protocol.makeConnection(proxy_server_transport)
  385. # ... and replace the protocol on the proxy's transport with the
  386. # TLSMemoryBIOProtocol for the test server, so that incoming traffic
  387. # to the proxy gets sent over to the HTTP(s) server.
  388. # See also comment at `_do_https_request_via_proxy`
  389. # in ../test_proxyagent.py for more details
  390. if expect_proxy_ssl:
  391. assert isinstance(proxy_server_transport, TLSMemoryBIOProtocol)
  392. proxy_server_transport.wrappedProtocol = server_ssl_protocol
  393. else:
  394. assert isinstance(proxy_server_transport, FakeTransport)
  395. client_protocol = proxy_server_transport.other
  396. assert isinstance(client_protocol, Protocol)
  397. c2s_transport = checked_cast(FakeTransport, client_protocol.transport)
  398. c2s_transport.other = server_ssl_protocol
  399. self.reactor.advance(0)
  400. server_name = server_ssl_protocol._tlsConnection.get_servername()
  401. expected_sni = b"testserv"
  402. self.assertEqual(
  403. server_name,
  404. expected_sni,
  405. f"Expected SNI {expected_sni!s} but got {server_name!s}",
  406. )
  407. # now there should be a pending request
  408. http_server = server_ssl_protocol.wrappedProtocol
  409. assert isinstance(http_server, HTTPChannel)
  410. self.assertEqual(len(http_server.requests), 1)
  411. request = http_server.requests[0]
  412. self.assertEqual(request.method, b"GET")
  413. self.assertEqual(request.path, b"/foo/bar")
  414. self.assertEqual(
  415. request.requestHeaders.getRawHeaders(b"host"), [b"testserv:8448"]
  416. )
  417. self.assertEqual(
  418. request.requestHeaders.getRawHeaders(b"user-agent"), [b"test-agent"]
  419. )
  420. # Check that the destination server DID NOT receive proxy credentials
  421. self.assertIsNone(request.requestHeaders.getRawHeaders(b"Proxy-Authorization"))
  422. content = request.content.read()
  423. self.assertEqual(content, b"")
  424. # Deferred is still without a result
  425. self.assertNoResult(test_d)
  426. # send the headers
  427. request.responseHeaders.setRawHeaders(b"Content-Type", [b"application/json"])
  428. request.write("")
  429. self.reactor.pump((0.1,))
  430. response = self.successResultOf(test_d)
  431. # that should give us a Response object
  432. self.assertEqual(response.code, 200)
  433. # Send the body
  434. request.write(b'{ "a": 1 }')
  435. request.finish()
  436. self.reactor.pump((0.1,))
  437. # check it can be read
  438. json = self.successResultOf(treq.json_content(response))
  439. self.assertEqual(json, {"a": 1})
  440. def test_get_ip_address(self) -> None:
  441. """
  442. Test the behaviour when the server name contains an explicit IP (with no port)
  443. """
  444. self.agent = self._make_agent()
  445. # there will be a getaddrinfo on the IP
  446. self.reactor.lookups["1.2.3.4"] = "1.2.3.4"
  447. test_d = self._make_get_request(b"matrix-federation://1.2.3.4/foo/bar")
  448. # Nothing happened yet
  449. self.assertNoResult(test_d)
  450. # Make sure treq is trying to connect
  451. clients = self.reactor.tcpClients
  452. self.assertEqual(len(clients), 1)
  453. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  454. self.assertEqual(host, "1.2.3.4")
  455. self.assertEqual(port, 8448)
  456. # make a test server, and wire up the client
  457. http_server = self._make_connection(client_factory, expected_sni=None)
  458. self.assertEqual(len(http_server.requests), 1)
  459. request = http_server.requests[0]
  460. self.assertEqual(request.method, b"GET")
  461. self.assertEqual(request.path, b"/foo/bar")
  462. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"1.2.3.4"])
  463. # finish the request
  464. request.finish()
  465. self.reactor.pump((0.1,))
  466. self.successResultOf(test_d)
  467. def test_get_ipv6_address(self) -> None:
  468. """
  469. Test the behaviour when the server name contains an explicit IPv6 address
  470. (with no port)
  471. """
  472. self.agent = self._make_agent()
  473. # there will be a getaddrinfo on the IP
  474. self.reactor.lookups["::1"] = "::1"
  475. test_d = self._make_get_request(b"matrix-federation://[::1]/foo/bar")
  476. # Nothing happened yet
  477. self.assertNoResult(test_d)
  478. # Make sure treq is trying to connect
  479. clients = self.reactor.tcpClients
  480. self.assertEqual(len(clients), 1)
  481. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  482. self.assertEqual(host, "::1")
  483. self.assertEqual(port, 8448)
  484. # make a test server, and wire up the client
  485. http_server = self._make_connection(client_factory, expected_sni=None)
  486. self.assertEqual(len(http_server.requests), 1)
  487. request = http_server.requests[0]
  488. self.assertEqual(request.method, b"GET")
  489. self.assertEqual(request.path, b"/foo/bar")
  490. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"[::1]"])
  491. # finish the request
  492. request.finish()
  493. self.reactor.pump((0.1,))
  494. self.successResultOf(test_d)
  495. def test_get_ipv6_address_with_port(self) -> None:
  496. """
  497. Test the behaviour when the server name contains an explicit IPv6 address
  498. (with explicit port)
  499. """
  500. self.agent = self._make_agent()
  501. # there will be a getaddrinfo on the IP
  502. self.reactor.lookups["::1"] = "::1"
  503. test_d = self._make_get_request(b"matrix-federation://[::1]:80/foo/bar")
  504. # Nothing happened yet
  505. self.assertNoResult(test_d)
  506. # Make sure treq is trying to connect
  507. clients = self.reactor.tcpClients
  508. self.assertEqual(len(clients), 1)
  509. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  510. self.assertEqual(host, "::1")
  511. self.assertEqual(port, 80)
  512. # make a test server, and wire up the client
  513. http_server = self._make_connection(client_factory, expected_sni=None)
  514. self.assertEqual(len(http_server.requests), 1)
  515. request = http_server.requests[0]
  516. self.assertEqual(request.method, b"GET")
  517. self.assertEqual(request.path, b"/foo/bar")
  518. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"[::1]:80"])
  519. # finish the request
  520. request.finish()
  521. self.reactor.pump((0.1,))
  522. self.successResultOf(test_d)
  523. def test_get_hostname_bad_cert(self) -> None:
  524. """
  525. Test the behaviour when the certificate on the server doesn't match the hostname
  526. """
  527. self.agent = self._make_agent()
  528. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  529. self.reactor.lookups["testserv1"] = "1.2.3.4"
  530. test_d = self._make_get_request(b"matrix-federation://testserv1/foo/bar")
  531. # Nothing happened yet
  532. self.assertNoResult(test_d)
  533. # No SRV record lookup yet
  534. self.mock_resolver.resolve_service.assert_not_called()
  535. # there should be an attempt to connect on port 443 for the .well-known
  536. clients = self.reactor.tcpClients
  537. self.assertEqual(len(clients), 1)
  538. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  539. self.assertEqual(host, "1.2.3.4")
  540. self.assertEqual(port, 443)
  541. # fonx the connection
  542. client_factory.clientConnectionFailed(None, Exception("nope"))
  543. # attemptdelay on the hostnameendpoint is 0.3, so takes that long before the
  544. # .well-known request fails.
  545. self.reactor.pump((0.4,))
  546. # now there should be a SRV lookup
  547. self.mock_resolver.resolve_service.assert_called_once_with(
  548. b"_matrix._tcp.testserv1"
  549. )
  550. # we should fall back to a direct connection
  551. self.assertEqual(len(clients), 2)
  552. (host, port, client_factory, _timeout, _bindAddress) = clients[1]
  553. self.assertEqual(host, "1.2.3.4")
  554. self.assertEqual(port, 8448)
  555. # make a test server, and wire up the client
  556. http_server = self._make_connection(client_factory, expected_sni=b"testserv1")
  557. # there should be no requests
  558. self.assertEqual(len(http_server.requests), 0)
  559. # ... and the request should have failed
  560. e = self.failureResultOf(test_d, ResponseNeverReceived)
  561. failure_reason = e.value.reasons[0]
  562. self.assertIsInstance(failure_reason.value, VerificationError)
  563. def test_get_ip_address_bad_cert(self) -> None:
  564. """
  565. Test the behaviour when the server name contains an explicit IP, but
  566. the server cert doesn't cover it
  567. """
  568. self.agent = self._make_agent()
  569. # there will be a getaddrinfo on the IP
  570. self.reactor.lookups["1.2.3.5"] = "1.2.3.5"
  571. test_d = self._make_get_request(b"matrix-federation://1.2.3.5/foo/bar")
  572. # Nothing happened yet
  573. self.assertNoResult(test_d)
  574. # Make sure treq is trying to connect
  575. clients = self.reactor.tcpClients
  576. self.assertEqual(len(clients), 1)
  577. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  578. self.assertEqual(host, "1.2.3.5")
  579. self.assertEqual(port, 8448)
  580. # make a test server, and wire up the client
  581. http_server = self._make_connection(client_factory, expected_sni=None)
  582. # there should be no requests
  583. self.assertEqual(len(http_server.requests), 0)
  584. # ... and the request should have failed
  585. e = self.failureResultOf(test_d, ResponseNeverReceived)
  586. failure_reason = e.value.reasons[0]
  587. self.assertIsInstance(failure_reason.value, VerificationError)
  588. def test_get_no_srv_no_well_known(self) -> None:
  589. """
  590. Test the behaviour when the server name has no port, no SRV, and no well-known
  591. """
  592. self.agent = self._make_agent()
  593. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  594. self.reactor.lookups["testserv"] = "1.2.3.4"
  595. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  596. # Nothing happened yet
  597. self.assertNoResult(test_d)
  598. # No SRV record lookup yet
  599. self.mock_resolver.resolve_service.assert_not_called()
  600. # there should be an attempt to connect on port 443 for the .well-known
  601. clients = self.reactor.tcpClients
  602. self.assertEqual(len(clients), 1)
  603. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  604. self.assertEqual(host, "1.2.3.4")
  605. self.assertEqual(port, 443)
  606. # fonx the connection
  607. client_factory.clientConnectionFailed(None, Exception("nope"))
  608. # attemptdelay on the hostnameendpoint is 0.3, so takes that long before the
  609. # .well-known request fails.
  610. self.reactor.pump((0.4,))
  611. # now there should be a SRV lookup
  612. self.mock_resolver.resolve_service.assert_called_once_with(
  613. b"_matrix._tcp.testserv"
  614. )
  615. # we should fall back to a direct connection
  616. self.assertEqual(len(clients), 2)
  617. (host, port, client_factory, _timeout, _bindAddress) = clients[1]
  618. self.assertEqual(host, "1.2.3.4")
  619. self.assertEqual(port, 8448)
  620. # make a test server, and wire up the client
  621. http_server = self._make_connection(client_factory, expected_sni=b"testserv")
  622. self.assertEqual(len(http_server.requests), 1)
  623. request = http_server.requests[0]
  624. self.assertEqual(request.method, b"GET")
  625. self.assertEqual(request.path, b"/foo/bar")
  626. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"testserv"])
  627. # finish the request
  628. request.finish()
  629. self.reactor.pump((0.1,))
  630. self.successResultOf(test_d)
  631. def test_get_well_known(self) -> None:
  632. """Test the behaviour when the .well-known delegates elsewhere"""
  633. self.agent = self._make_agent()
  634. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  635. self.reactor.lookups["testserv"] = "1.2.3.4"
  636. self.reactor.lookups["target-server"] = "1::f"
  637. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  638. # Nothing happened yet
  639. self.assertNoResult(test_d)
  640. # there should be an attempt to connect on port 443 for the .well-known
  641. clients = self.reactor.tcpClients
  642. self.assertEqual(len(clients), 1)
  643. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  644. self.assertEqual(host, "1.2.3.4")
  645. self.assertEqual(port, 443)
  646. self._handle_well_known_connection(
  647. client_factory,
  648. expected_sni=b"testserv",
  649. content=b'{ "m.server": "target-server" }',
  650. )
  651. # there should be a SRV lookup
  652. self.mock_resolver.resolve_service.assert_called_once_with(
  653. b"_matrix._tcp.target-server"
  654. )
  655. # now we should get a connection to the target server
  656. self.assertEqual(len(clients), 2)
  657. (host, port, client_factory, _timeout, _bindAddress) = clients[1]
  658. self.assertEqual(host, "1::f")
  659. self.assertEqual(port, 8448)
  660. # make a test server, and wire up the client
  661. http_server = self._make_connection(
  662. client_factory, expected_sni=b"target-server"
  663. )
  664. self.assertEqual(len(http_server.requests), 1)
  665. request = http_server.requests[0]
  666. self.assertEqual(request.method, b"GET")
  667. self.assertEqual(request.path, b"/foo/bar")
  668. self.assertEqual(
  669. request.requestHeaders.getRawHeaders(b"host"), [b"target-server"]
  670. )
  671. # finish the request
  672. request.finish()
  673. self.reactor.pump((0.1,))
  674. self.successResultOf(test_d)
  675. self.assertEqual(self.well_known_cache[b"testserv"], b"target-server")
  676. # check the cache expires
  677. self.reactor.pump((48 * 3600,))
  678. self.well_known_cache.expire()
  679. self.assertNotIn(b"testserv", self.well_known_cache)
  680. def test_get_well_known_redirect(self) -> None:
  681. """Test the behaviour when the server name has no port and no SRV record, but
  682. the .well-known has a 300 redirect
  683. """
  684. self.agent = self._make_agent()
  685. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  686. self.reactor.lookups["testserv"] = "1.2.3.4"
  687. self.reactor.lookups["target-server"] = "1::f"
  688. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  689. # Nothing happened yet
  690. self.assertNoResult(test_d)
  691. # there should be an attempt to connect on port 443 for the .well-known
  692. clients = self.reactor.tcpClients
  693. self.assertEqual(len(clients), 1)
  694. (host, port, client_factory, _timeout, _bindAddress) = clients.pop()
  695. self.assertEqual(host, "1.2.3.4")
  696. self.assertEqual(port, 443)
  697. redirect_server = self._make_connection(
  698. client_factory, expected_sni=b"testserv"
  699. )
  700. # send a 302 redirect
  701. self.assertEqual(len(redirect_server.requests), 1)
  702. request = redirect_server.requests[0]
  703. request.redirect(b"https://testserv/even_better_known")
  704. request.finish()
  705. self.reactor.pump((0.1,))
  706. # now there should be another connection
  707. clients = self.reactor.tcpClients
  708. self.assertEqual(len(clients), 1)
  709. (host, port, client_factory, _timeout, _bindAddress) = clients.pop()
  710. self.assertEqual(host, "1.2.3.4")
  711. self.assertEqual(port, 443)
  712. well_known_server = self._make_connection(
  713. client_factory, expected_sni=b"testserv"
  714. )
  715. self.assertEqual(len(well_known_server.requests), 1, "No request after 302")
  716. request = well_known_server.requests[0]
  717. self.assertEqual(request.method, b"GET")
  718. self.assertEqual(request.path, b"/even_better_known")
  719. request.write(b'{ "m.server": "target-server" }')
  720. request.finish()
  721. self.reactor.pump((0.1,))
  722. # there should be a SRV lookup
  723. self.mock_resolver.resolve_service.assert_called_once_with(
  724. b"_matrix._tcp.target-server"
  725. )
  726. # now we should get a connection to the target server
  727. self.assertEqual(len(clients), 1)
  728. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  729. self.assertEqual(host, "1::f")
  730. self.assertEqual(port, 8448)
  731. # make a test server, and wire up the client
  732. http_server = self._make_connection(
  733. client_factory, expected_sni=b"target-server"
  734. )
  735. self.assertEqual(len(http_server.requests), 1)
  736. request = http_server.requests[0]
  737. self.assertEqual(request.method, b"GET")
  738. self.assertEqual(request.path, b"/foo/bar")
  739. self.assertEqual(
  740. request.requestHeaders.getRawHeaders(b"host"), [b"target-server"]
  741. )
  742. # finish the request
  743. request.finish()
  744. self.reactor.pump((0.1,))
  745. self.successResultOf(test_d)
  746. self.assertEqual(self.well_known_cache[b"testserv"], b"target-server")
  747. # check the cache expires
  748. self.reactor.pump((48 * 3600,))
  749. self.well_known_cache.expire()
  750. self.assertNotIn(b"testserv", self.well_known_cache)
  751. def test_get_invalid_well_known(self) -> None:
  752. """
  753. Test the behaviour when the server name has an *invalid* well-known (and no SRV)
  754. """
  755. self.agent = self._make_agent()
  756. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  757. self.reactor.lookups["testserv"] = "1.2.3.4"
  758. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  759. # Nothing happened yet
  760. self.assertNoResult(test_d)
  761. # No SRV record lookup yet
  762. self.mock_resolver.resolve_service.assert_not_called()
  763. # there should be an attempt to connect on port 443 for the .well-known
  764. clients = self.reactor.tcpClients
  765. self.assertEqual(len(clients), 1)
  766. (host, port, client_factory, _timeout, _bindAddress) = clients.pop()
  767. self.assertEqual(host, "1.2.3.4")
  768. self.assertEqual(port, 443)
  769. self._handle_well_known_connection(
  770. client_factory, expected_sni=b"testserv", content=b"NOT JSON"
  771. )
  772. # now there should be a SRV lookup
  773. self.mock_resolver.resolve_service.assert_called_once_with(
  774. b"_matrix._tcp.testserv"
  775. )
  776. # we should fall back to a direct connection
  777. self.assertEqual(len(clients), 1)
  778. (host, port, client_factory, _timeout, _bindAddress) = clients.pop()
  779. self.assertEqual(host, "1.2.3.4")
  780. self.assertEqual(port, 8448)
  781. # make a test server, and wire up the client
  782. http_server = self._make_connection(client_factory, expected_sni=b"testserv")
  783. self.assertEqual(len(http_server.requests), 1)
  784. request = http_server.requests[0]
  785. self.assertEqual(request.method, b"GET")
  786. self.assertEqual(request.path, b"/foo/bar")
  787. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"testserv"])
  788. # finish the request
  789. request.finish()
  790. self.reactor.pump((0.1,))
  791. self.successResultOf(test_d)
  792. def test_get_well_known_unsigned_cert(self) -> None:
  793. """Test the behaviour when the .well-known server presents a cert
  794. not signed by a CA
  795. """
  796. # we use the same test server as the other tests, but use an agent with
  797. # the config left to the default, which will not trust it (since the
  798. # presented cert is signed by a test CA)
  799. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  800. self.reactor.lookups["testserv"] = "1.2.3.4"
  801. config = default_config("test", parse=True)
  802. # Build a new agent and WellKnownResolver with a different tls factory
  803. tls_factory = FederationPolicyForHTTPS(config)
  804. agent = MatrixFederationAgent(
  805. reactor=self.reactor,
  806. tls_client_options_factory=tls_factory,
  807. user_agent=b"test-agent", # This is unused since _well_known_resolver is passed below.
  808. ip_allowlist=IPSet(),
  809. ip_blocklist=IPSet(),
  810. _srv_resolver=self.mock_resolver,
  811. _well_known_resolver=WellKnownResolver(
  812. cast(ISynapseReactor, self.reactor),
  813. Agent(self.reactor, contextFactory=tls_factory),
  814. b"test-agent",
  815. well_known_cache=self.well_known_cache,
  816. had_well_known_cache=self.had_well_known_cache,
  817. ),
  818. )
  819. test_d = agent.request(b"GET", b"matrix-federation://testserv/foo/bar")
  820. # Nothing happened yet
  821. self.assertNoResult(test_d)
  822. # there should be an attempt to connect on port 443 for the .well-known
  823. clients = self.reactor.tcpClients
  824. self.assertEqual(len(clients), 1)
  825. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  826. self.assertEqual(host, "1.2.3.4")
  827. self.assertEqual(port, 443)
  828. http_proto = self._make_connection(client_factory, expected_sni=b"testserv")
  829. # there should be no requests
  830. self.assertEqual(len(http_proto.requests), 0)
  831. # and there should be a SRV lookup instead
  832. self.mock_resolver.resolve_service.assert_called_once_with(
  833. b"_matrix._tcp.testserv"
  834. )
  835. def test_get_hostname_srv(self) -> None:
  836. """
  837. Test the behaviour when there is a single SRV record
  838. """
  839. self.agent = self._make_agent()
  840. self.mock_resolver.resolve_service.side_effect = generate_resolve_service(
  841. [Server(host=b"srvtarget", port=8443)]
  842. )
  843. self.reactor.lookups["srvtarget"] = "1.2.3.4"
  844. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  845. # Nothing happened yet
  846. self.assertNoResult(test_d)
  847. # the request for a .well-known will have failed with a DNS lookup error.
  848. self.mock_resolver.resolve_service.assert_called_once_with(
  849. b"_matrix._tcp.testserv"
  850. )
  851. # Make sure treq is trying to connect
  852. clients = self.reactor.tcpClients
  853. self.assertEqual(len(clients), 1)
  854. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  855. self.assertEqual(host, "1.2.3.4")
  856. self.assertEqual(port, 8443)
  857. # make a test server, and wire up the client
  858. http_server = self._make_connection(client_factory, expected_sni=b"testserv")
  859. self.assertEqual(len(http_server.requests), 1)
  860. request = http_server.requests[0]
  861. self.assertEqual(request.method, b"GET")
  862. self.assertEqual(request.path, b"/foo/bar")
  863. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"testserv"])
  864. # finish the request
  865. request.finish()
  866. self.reactor.pump((0.1,))
  867. self.successResultOf(test_d)
  868. def test_get_well_known_srv(self) -> None:
  869. """Test the behaviour when the .well-known redirects to a place where there
  870. is a SRV.
  871. """
  872. self.agent = self._make_agent()
  873. self.reactor.lookups["testserv"] = "1.2.3.4"
  874. self.reactor.lookups["srvtarget"] = "5.6.7.8"
  875. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  876. # Nothing happened yet
  877. self.assertNoResult(test_d)
  878. # there should be an attempt to connect on port 443 for the .well-known
  879. clients = self.reactor.tcpClients
  880. self.assertEqual(len(clients), 1)
  881. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  882. self.assertEqual(host, "1.2.3.4")
  883. self.assertEqual(port, 443)
  884. self.mock_resolver.resolve_service.side_effect = generate_resolve_service(
  885. [Server(host=b"srvtarget", port=8443)]
  886. )
  887. self._handle_well_known_connection(
  888. client_factory,
  889. expected_sni=b"testserv",
  890. content=b'{ "m.server": "target-server" }',
  891. )
  892. # there should be a SRV lookup
  893. self.mock_resolver.resolve_service.assert_called_once_with(
  894. b"_matrix._tcp.target-server"
  895. )
  896. # now we should get a connection to the target of the SRV record
  897. self.assertEqual(len(clients), 2)
  898. (host, port, client_factory, _timeout, _bindAddress) = clients[1]
  899. self.assertEqual(host, "5.6.7.8")
  900. self.assertEqual(port, 8443)
  901. # make a test server, and wire up the client
  902. http_server = self._make_connection(
  903. client_factory, expected_sni=b"target-server"
  904. )
  905. self.assertEqual(len(http_server.requests), 1)
  906. request = http_server.requests[0]
  907. self.assertEqual(request.method, b"GET")
  908. self.assertEqual(request.path, b"/foo/bar")
  909. self.assertEqual(
  910. request.requestHeaders.getRawHeaders(b"host"), [b"target-server"]
  911. )
  912. # finish the request
  913. request.finish()
  914. self.reactor.pump((0.1,))
  915. self.successResultOf(test_d)
  916. def test_idna_servername(self) -> None:
  917. """test the behaviour when the server name has idna chars in"""
  918. self.agent = self._make_agent()
  919. self.mock_resolver.resolve_service.side_effect = generate_resolve_service([])
  920. # the resolver is always called with the IDNA hostname as a native string.
  921. self.reactor.lookups["xn--bcher-kva.com"] = "1.2.3.4"
  922. # this is idna for bücher.com
  923. test_d = self._make_get_request(
  924. b"matrix-federation://xn--bcher-kva.com/foo/bar"
  925. )
  926. # Nothing happened yet
  927. self.assertNoResult(test_d)
  928. # No SRV record lookup yet
  929. self.mock_resolver.resolve_service.assert_not_called()
  930. # there should be an attempt to connect on port 443 for the .well-known
  931. clients = self.reactor.tcpClients
  932. self.assertEqual(len(clients), 1)
  933. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  934. self.assertEqual(host, "1.2.3.4")
  935. self.assertEqual(port, 443)
  936. # fonx the connection
  937. client_factory.clientConnectionFailed(None, Exception("nope"))
  938. # attemptdelay on the hostnameendpoint is 0.3, so takes that long before the
  939. # .well-known request fails.
  940. self.reactor.pump((0.4,))
  941. # now there should have been a SRV lookup
  942. self.mock_resolver.resolve_service.assert_called_once_with(
  943. b"_matrix._tcp.xn--bcher-kva.com"
  944. )
  945. # We should fall back to port 8448
  946. clients = self.reactor.tcpClients
  947. self.assertEqual(len(clients), 2)
  948. (host, port, client_factory, _timeout, _bindAddress) = clients[1]
  949. self.assertEqual(host, "1.2.3.4")
  950. self.assertEqual(port, 8448)
  951. # make a test server, and wire up the client
  952. http_server = self._make_connection(
  953. client_factory, expected_sni=b"xn--bcher-kva.com"
  954. )
  955. self.assertEqual(len(http_server.requests), 1)
  956. request = http_server.requests[0]
  957. self.assertEqual(request.method, b"GET")
  958. self.assertEqual(request.path, b"/foo/bar")
  959. self.assertEqual(
  960. request.requestHeaders.getRawHeaders(b"host"), [b"xn--bcher-kva.com"]
  961. )
  962. # finish the request
  963. request.finish()
  964. self.reactor.pump((0.1,))
  965. self.successResultOf(test_d)
  966. def test_idna_srv_target(self) -> None:
  967. """test the behaviour when the target of a SRV record has idna chars"""
  968. self.agent = self._make_agent()
  969. self.mock_resolver.resolve_service.side_effect = generate_resolve_service(
  970. [Server(host=b"xn--trget-3qa.com", port=8443)] # târget.com
  971. )
  972. self.reactor.lookups["xn--trget-3qa.com"] = "1.2.3.4"
  973. test_d = self._make_get_request(
  974. b"matrix-federation://xn--bcher-kva.com/foo/bar"
  975. )
  976. # Nothing happened yet
  977. self.assertNoResult(test_d)
  978. self.mock_resolver.resolve_service.assert_called_once_with(
  979. b"_matrix._tcp.xn--bcher-kva.com"
  980. )
  981. # Make sure treq is trying to connect
  982. clients = self.reactor.tcpClients
  983. self.assertEqual(len(clients), 1)
  984. (host, port, client_factory, _timeout, _bindAddress) = clients[0]
  985. self.assertEqual(host, "1.2.3.4")
  986. self.assertEqual(port, 8443)
  987. # make a test server, and wire up the client
  988. http_server = self._make_connection(
  989. client_factory, expected_sni=b"xn--bcher-kva.com"
  990. )
  991. self.assertEqual(len(http_server.requests), 1)
  992. request = http_server.requests[0]
  993. self.assertEqual(request.method, b"GET")
  994. self.assertEqual(request.path, b"/foo/bar")
  995. self.assertEqual(
  996. request.requestHeaders.getRawHeaders(b"host"), [b"xn--bcher-kva.com"]
  997. )
  998. # finish the request
  999. request.finish()
  1000. self.reactor.pump((0.1,))
  1001. self.successResultOf(test_d)
  1002. def test_well_known_cache(self) -> None:
  1003. self.reactor.lookups["testserv"] = "1.2.3.4"
  1004. fetch_d = defer.ensureDeferred(
  1005. self.well_known_resolver.get_well_known(b"testserv")
  1006. )
  1007. # there should be an attempt to connect on port 443 for the .well-known
  1008. clients = self.reactor.tcpClients
  1009. self.assertEqual(len(clients), 1)
  1010. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1011. self.assertEqual(host, "1.2.3.4")
  1012. self.assertEqual(port, 443)
  1013. well_known_server = self._handle_well_known_connection(
  1014. client_factory,
  1015. expected_sni=b"testserv",
  1016. response_headers={b"Cache-Control": b"max-age=1000"},
  1017. content=b'{ "m.server": "target-server" }',
  1018. )
  1019. r = self.successResultOf(fetch_d)
  1020. self.assertEqual(r.delegated_server, b"target-server")
  1021. # close the tcp connection
  1022. well_known_server.loseConnection()
  1023. # repeat the request: it should hit the cache
  1024. fetch_d = defer.ensureDeferred(
  1025. self.well_known_resolver.get_well_known(b"testserv")
  1026. )
  1027. r = self.successResultOf(fetch_d)
  1028. self.assertEqual(r.delegated_server, b"target-server")
  1029. # expire the cache
  1030. self.reactor.pump((1000.0,))
  1031. # now it should connect again
  1032. fetch_d = defer.ensureDeferred(
  1033. self.well_known_resolver.get_well_known(b"testserv")
  1034. )
  1035. self.assertEqual(len(clients), 1)
  1036. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1037. self.assertEqual(host, "1.2.3.4")
  1038. self.assertEqual(port, 443)
  1039. self._handle_well_known_connection(
  1040. client_factory,
  1041. expected_sni=b"testserv",
  1042. content=b'{ "m.server": "other-server" }',
  1043. )
  1044. r = self.successResultOf(fetch_d)
  1045. self.assertEqual(r.delegated_server, b"other-server")
  1046. def test_well_known_cache_with_temp_failure(self) -> None:
  1047. """Test that we refetch well-known before the cache expires, and that
  1048. it ignores transient errors.
  1049. """
  1050. self.reactor.lookups["testserv"] = "1.2.3.4"
  1051. fetch_d = defer.ensureDeferred(
  1052. self.well_known_resolver.get_well_known(b"testserv")
  1053. )
  1054. # there should be an attempt to connect on port 443 for the .well-known
  1055. clients = self.reactor.tcpClients
  1056. self.assertEqual(len(clients), 1)
  1057. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1058. self.assertEqual(host, "1.2.3.4")
  1059. self.assertEqual(port, 443)
  1060. well_known_server = self._handle_well_known_connection(
  1061. client_factory,
  1062. expected_sni=b"testserv",
  1063. response_headers={b"Cache-Control": b"max-age=1000"},
  1064. content=b'{ "m.server": "target-server" }',
  1065. )
  1066. r = self.successResultOf(fetch_d)
  1067. self.assertEqual(r.delegated_server, b"target-server")
  1068. # close the tcp connection
  1069. well_known_server.loseConnection()
  1070. # Get close to the cache expiry, this will cause the resolver to do
  1071. # another lookup.
  1072. self.reactor.pump((900.0,))
  1073. fetch_d = defer.ensureDeferred(
  1074. self.well_known_resolver.get_well_known(b"testserv")
  1075. )
  1076. # The resolver may retry a few times, so fonx all requests that come along
  1077. attempts = 0
  1078. while self.reactor.tcpClients:
  1079. clients = self.reactor.tcpClients
  1080. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1081. attempts += 1
  1082. # fonx the connection attempt, this will be treated as a temporary
  1083. # failure.
  1084. client_factory.clientConnectionFailed(None, Exception("nope"))
  1085. # There's a few sleeps involved, so we have to pump the reactor a
  1086. # bit.
  1087. self.reactor.pump((1.0, 1.0))
  1088. # We expect to see more than one attempt as there was previously a valid
  1089. # well known.
  1090. self.assertGreater(attempts, 1)
  1091. # Resolver should return cached value, despite the lookup failing.
  1092. r = self.successResultOf(fetch_d)
  1093. self.assertEqual(r.delegated_server, b"target-server")
  1094. # Expire both caches and repeat the request
  1095. self.reactor.pump((10000.0,))
  1096. # Repeat the request, this time it should fail if the lookup fails.
  1097. fetch_d = defer.ensureDeferred(
  1098. self.well_known_resolver.get_well_known(b"testserv")
  1099. )
  1100. clients = self.reactor.tcpClients
  1101. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1102. client_factory.clientConnectionFailed(None, Exception("nope"))
  1103. self.reactor.pump((0.4,))
  1104. r = self.successResultOf(fetch_d)
  1105. self.assertEqual(r.delegated_server, None)
  1106. def test_well_known_too_large(self) -> None:
  1107. """A well-known query that returns a result which is too large should be rejected."""
  1108. self.reactor.lookups["testserv"] = "1.2.3.4"
  1109. fetch_d = defer.ensureDeferred(
  1110. self.well_known_resolver.get_well_known(b"testserv")
  1111. )
  1112. # there should be an attempt to connect on port 443 for the .well-known
  1113. clients = self.reactor.tcpClients
  1114. self.assertEqual(len(clients), 1)
  1115. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1116. self.assertEqual(host, "1.2.3.4")
  1117. self.assertEqual(port, 443)
  1118. self._handle_well_known_connection(
  1119. client_factory,
  1120. expected_sni=b"testserv",
  1121. response_headers={b"Cache-Control": b"max-age=1000"},
  1122. content=b'{ "m.server": "' + (b"a" * WELL_KNOWN_MAX_SIZE) + b'" }',
  1123. )
  1124. # The result is successful, but disabled delegation.
  1125. r = self.successResultOf(fetch_d)
  1126. self.assertIsNone(r.delegated_server)
  1127. def test_srv_fallbacks(self) -> None:
  1128. """Test that other SRV results are tried if the first one fails."""
  1129. self.agent = self._make_agent()
  1130. self.mock_resolver.resolve_service.side_effect = generate_resolve_service(
  1131. [
  1132. Server(host=b"target.com", port=8443),
  1133. Server(host=b"target.com", port=8444),
  1134. ]
  1135. )
  1136. self.reactor.lookups["target.com"] = "1.2.3.4"
  1137. test_d = self._make_get_request(b"matrix-federation://testserv/foo/bar")
  1138. # Nothing happened yet
  1139. self.assertNoResult(test_d)
  1140. self.mock_resolver.resolve_service.assert_called_once_with(
  1141. b"_matrix._tcp.testserv"
  1142. )
  1143. # We should see an attempt to connect to the first server
  1144. clients = self.reactor.tcpClients
  1145. self.assertEqual(len(clients), 1)
  1146. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1147. self.assertEqual(host, "1.2.3.4")
  1148. self.assertEqual(port, 8443)
  1149. # Fonx the connection
  1150. client_factory.clientConnectionFailed(None, Exception("nope"))
  1151. # There's a 300ms delay in HostnameEndpoint
  1152. self.reactor.pump((0.4,))
  1153. # Hasn't failed yet
  1154. self.assertNoResult(test_d)
  1155. # We shouldnow see an attempt to connect to the second server
  1156. clients = self.reactor.tcpClients
  1157. self.assertEqual(len(clients), 1)
  1158. (host, port, client_factory, _timeout, _bindAddress) = clients.pop(0)
  1159. self.assertEqual(host, "1.2.3.4")
  1160. self.assertEqual(port, 8444)
  1161. # make a test server, and wire up the client
  1162. http_server = self._make_connection(client_factory, expected_sni=b"testserv")
  1163. self.assertEqual(len(http_server.requests), 1)
  1164. request = http_server.requests[0]
  1165. self.assertEqual(request.method, b"GET")
  1166. self.assertEqual(request.path, b"/foo/bar")
  1167. self.assertEqual(request.requestHeaders.getRawHeaders(b"host"), [b"testserv"])
  1168. # finish the request
  1169. request.finish()
  1170. self.reactor.pump((0.1,))
  1171. self.successResultOf(test_d)
  1172. class TestCachePeriodFromHeaders(unittest.TestCase):
  1173. def test_cache_control(self) -> None:
  1174. # uppercase
  1175. self.assertEqual(
  1176. _cache_period_from_headers(
  1177. Headers({b"Cache-Control": [b"foo, Max-Age = 100, bar"]})
  1178. ),
  1179. 100,
  1180. )
  1181. # missing value
  1182. self.assertIsNone(
  1183. _cache_period_from_headers(Headers({b"Cache-Control": [b"max-age=, bar"]}))
  1184. )
  1185. # hackernews: bogus due to semicolon
  1186. self.assertIsNone(
  1187. _cache_period_from_headers(
  1188. Headers({b"Cache-Control": [b"private; max-age=0"]})
  1189. )
  1190. )
  1191. # github
  1192. self.assertEqual(
  1193. _cache_period_from_headers(
  1194. Headers({b"Cache-Control": [b"max-age=0, private, must-revalidate"]})
  1195. ),
  1196. 0,
  1197. )
  1198. # google
  1199. self.assertEqual(
  1200. _cache_period_from_headers(
  1201. Headers({b"cache-control": [b"private, max-age=0"]})
  1202. ),
  1203. 0,
  1204. )
  1205. def test_expires(self) -> None:
  1206. self.assertEqual(
  1207. _cache_period_from_headers(
  1208. Headers({b"Expires": [b"Wed, 30 Jan 2019 07:35:33 GMT"]}),
  1209. time_now=lambda: 1548833700,
  1210. ),
  1211. 33,
  1212. )
  1213. # cache-control overrides expires
  1214. self.assertEqual(
  1215. _cache_period_from_headers(
  1216. Headers(
  1217. {
  1218. b"cache-control": [b"max-age=10"],
  1219. b"Expires": [b"Wed, 30 Jan 2019 07:35:33 GMT"],
  1220. }
  1221. ),
  1222. time_now=lambda: 1548833700,
  1223. ),
  1224. 10,
  1225. )
  1226. # invalid expires means immediate expiry
  1227. self.assertEqual(_cache_period_from_headers(Headers({b"Expires": [b"0"]})), 0)
  1228. def _check_logcontext(context: LoggingContextOrSentinel) -> None:
  1229. current = current_context()
  1230. if current is not context:
  1231. raise AssertionError("Expected logcontext %s but was %s" % (context, current))
  1232. def _wrap_server_factory_for_tls(
  1233. factory: IProtocolFactory, sanlist: Optional[List[bytes]] = None
  1234. ) -> TLSMemoryBIOFactory:
  1235. """Wrap an existing Protocol Factory with a test TLSMemoryBIOFactory
  1236. The resultant factory will create a TLS server which presents a certificate
  1237. signed by our test CA, valid for the domains in `sanlist`
  1238. Args:
  1239. factory: protocol factory to wrap
  1240. sanlist: list of domains the cert should be valid for
  1241. Returns:
  1242. interfaces.IProtocolFactory
  1243. """
  1244. if sanlist is None:
  1245. sanlist = [
  1246. b"DNS:testserv",
  1247. b"DNS:target-server",
  1248. b"DNS:xn--bcher-kva.com",
  1249. b"IP:1.2.3.4",
  1250. b"IP:::1",
  1251. ]
  1252. connection_creator = TestServerTLSConnectionFactory(sanlist=sanlist)
  1253. return TLSMemoryBIOFactory(
  1254. connection_creator, isClient=False, wrappedFactory=factory
  1255. )
  1256. def _get_test_protocol_factory() -> IProtocolFactory:
  1257. """Get a protocol Factory which will build an HTTPChannel
  1258. Returns:
  1259. interfaces.IProtocolFactory
  1260. """
  1261. server_factory = Factory.forProtocol(HTTPChannel)
  1262. # Request.finish expects the factory to have a 'log' method.
  1263. server_factory.log = _log_request
  1264. return server_factory
  1265. def _log_request(request: str) -> None:
  1266. """Implements Factory.log, which is expected by Request.finish"""
  1267. logger.info(f"Completed request {request}")
  1268. @implementer(IPolicyForHTTPS)
  1269. class TrustingTLSPolicyForHTTPS:
  1270. """An IPolicyForHTTPS which checks that the certificate belongs to the
  1271. right server, but doesn't check the certificate chain."""
  1272. def creatorForNetloc(
  1273. self, hostname: bytes, port: int
  1274. ) -> IOpenSSLClientConnectionCreator:
  1275. certificateOptions = OpenSSLCertificateOptions()
  1276. return ClientTLSOptions(hostname, certificateOptions.getContext())